Fix: Render HTML in email error message on registration form#3901
Open
jitheng wants to merge 1 commit intoShopify:mainfrom
Open
Fix: Render HTML in email error message on registration form#3901jitheng wants to merge 1 commit intoShopify:mainfrom
jitheng wants to merge 1 commit intoShopify:mainfrom
Conversation
When registering with an already-used email address, Shopify returns an error message that contains an HTML anchor tag (e.g. <a href="/account/login#recover">reset your password</a>). The inline error span below the email field was rendering this as plain text because it prepended the field label and appended a hardcoded period, breaking HTML rendering. Fix: Remove the redundant field label prefix (translated_fields.email) and the hardcoded trailing period from the inline email error message output so that the full error message — including any HTML links — renders correctly. Fixes Shopify#3891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering with an already-used email address, Shopify returns an error message that contains an HTML anchor tag (e.g.
<a href="/account/login#recover">reset your password</a>). The inline error span below the email field was rendering this as plain text because it prepended the field label and appended a hardcoded period, breaking HTML rendering.Fix: Remove the redundant field label prefix (
translated_fields.email) and the hardcoded trailing period from the inline email error message output so that the full error message — including any HTML links — renders correctly.Fixes #3891
PR Summary:
When a customer tries to register with an email address already associated with a legacy account, the error message now correctly renders the "reset your password" link as a clickable anchor, rather than displaying raw HTML as plain text.