Require typed JSON output for new Hydrogen commands - #4041
Merged
Merged
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
dmerand
approved these changes
Sep 21, 2026
graygilmore
previously requested changes
Sep 21, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-output-lint
branch
from
September 23, 2026 12:30
4736b01 to
a4454dd
Compare
fredericoo
approved these changes
Sep 23, 2026
gonzaloriestra
dismissed
graygilmore’s stale review
September 23, 2026 13:07
Pending change already done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://github.com/shop/issues-develop/issues/23663
Hydrogen's ESLint configuration does not enforce the shared typed JSON output contract. New commands can therefore omit a JSON flag and result schema while the existing command inventory is being migrated.
WHAT is this pull request doing?
Enable
@shopify/cli/command-json-outputfor Hydrogen command source files and add a local exception list: 23 existing finite commands awaiting migration and 3 streaming commands. Document when to remove an exception. Raise the root ESLint version to 9.39.5 to satisfy the plugin's dependencies.Depends on Shopify/cli#8576 (already merged).
Checklist