Active model attributes model type#47
Open
seanpdoyle wants to merge 4 commits intoShopify:active-model-attributes-model-typefrom
Open
Active model attributes model type#47seanpdoyle wants to merge 4 commits intoShopify:active-model-attributes-model-typefrom
seanpdoyle wants to merge 4 commits intoShopify:active-model-attributes-model-typefrom
Conversation
These lines are causing [CI failures][]. To fix them, we can revert the changes to `User`, and instead utilize the new `Post` model class in `activemodel/test/cases/attributes_test.rb`. [CI failures]: https://buildkite.com/rails/rails/builds/105947
When assigning an instance of the class specified by the `:model` option, return that same instance.
When checking `Type::Model#valid_value?` (which relies on `#valid_hash?`), add support for models that have been assigned values to aliased attribute names.
First, register the `ActiveModel::Type::Model` with `ActiveRecord::Type`. Next, add test coverage for writing to and reading from a `TEXT` column. Include handling writing and reading of :model attributes that themselves contain nested :model attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The rails#51420 PR was opened as a copy of a prior PR that was closed. In its current state, CI is failing. It also lacks test coverage for Active Record-side support. This PR aims to fill in the gaps in order to make rails#51420 viable for merge.
Detail
Adjustments to the Active Model version of the attribute
The current PR's CI has failures.
To fix them, this PR reverts the changes to
User, and instead utilizesthe new
Postmodel class inactivemodel/test/cases/attributes_test.rb.These changes also propose that assigning an instance of the class specified by the
:modeloption should support returning that same instance when the attribute is read.
When checking
Type::Model#valid_value?(which relies on#valid_hash?), this PR adds support for models that have been assigned valuesto aliased attribute names.
Integrating with Active Record
The latter half of this PR's change adds test coverage for writing and reading
:modelattributes toTEXTandJSONcolumns.First, register the
ActiveModel::Type::ModelwithActiveRecord::Type.Next, add test coverage for writing to and reading from a
TEXTcolumn.Include handling writing and reading of :model attributes that
themselves contain nested :model attributes.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]