Start accepting --beta flag to install beta server version#3976
Open
Start accepting --beta flag to install beta server version#3976
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adopting the new indexer will be a process of ironing out bugs, ensuring all APIs are in place and making sure the implementation is robust.
We need a way to ship beta releases of the server to do this without being too disruptive, while at the same time getting feedback from users.
This PR starts accepting a
--betaflag when launching the Ruby LSP, which makes us install a beta release in the composed bundle.Implementation
The idea is to accept the new flag and use a Gemfile constraint to allow installing pre-release versions.
I avoided using the
--preflag because that applies to all dependencies and would end up trying to update to pre-releases ofrbs,prism,ruby-lsp-railsand so on. This constrains the surface area to justruby-lsp.Automated Tests
Added tests to verify that we generate the expected composed Gemfile when beta is on.