Skip to content

Return MethodNotFound (-32601) for unrecognized LSP requests #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgorFroehner wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −0
Open

Return MethodNotFound (-32601) for unrecognized LSP requests #4040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ff0a1e
Return MethodNotFound (-32601) for unrecognized LSP requests
IgorFroehner Mar 31, 2026
8a8da0c
Use a constant error code
IgorFroehner Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/ruby_lsp/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ def process_message(message)
@global_state.synchronize { @cancelled_requests << message[:params][:id] }
when nil
process_response(message) if message[:result]
else
id = message[:id]

if id
send_message(Error.new(
id: id,
code: Constant::ErrorCodes::METHOD_NOT_FOUND,
message: "Method not found: #{message[:method]}",
))
end
end
rescue DelegateRequestError
send_message(Error.new(id: message[:id], code: DelegateRequestError::CODE, message: "DELEGATE_REQUEST"))
Expand Down
13 changes: 13 additions & 0 deletions test/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,6 +1726,19 @@ def test_launch_bundle_compose_forwards_argv_to_launcher
ARGV.replace(original_argv)
end

def test_unrecognized_request_returns_method_not_found
non_existent_method = "textDocument/nonExistentMethod"
@server.process_message({
id: 1,
method: non_existent_method,
params: {},
})

error = find_message(RubyLsp::Error)
assert_equal(Constant::ErrorCodes::METHOD_NOT_FOUND, error.code)
assert_equal("Method not found: #{non_existent_method}", error.message)
end

private

def run_initialize_server_with_setup_error(error)
Expand Down
Loading