Skip to content

Validate host param in HomeController to prevent open redirect#198

Merged
amcaplan merged 1 commit intomainfrom
ac/validate-host-param
Mar 5, 2026
Merged

Validate host param in HomeController to prevent open redirect#198
amcaplan merged 1 commit intomainfrom
ac/validate-host-param

Conversation

@amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Mar 4, 2026

Summary

Apply the same deduced_phishing_attack? check from the shopify_app gem's generated HomeController template (Shopify/shopify_app#2059) to this template's HomeController.

Test plan

🤖 Generated with Claude Code

Apply the same deduced_phishing_attack? check used in the
shopify_app gem's generated HomeController template (Shopify/shopify_app#2059)
to this template's HomeController.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@amcaplan amcaplan merged commit 218a633 into main Mar 5, 2026
7 checks passed
@amcaplan amcaplan deleted the ac/validate-host-param branch March 5, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants