Skip non-theme directories when preloading files (for the LSP)

[elia]

What are you adding in this PR?

Fixes #1151.

When preloading files at startup, the language server was recursively loading all .json files under the theme root — including unrelated data files (e.g. data/orders.json). A single large JSON file parsed into an AST can consume 1–2 GB of heap, causing the server to OOM on repos that happen to have a data/ directory alongside the theme.

This change restricts preloading to Shopify theme directories only: assets, blocks, config, layout, locales, sections, snippets, templates.

What's next? Any followup issues?

None.

What did you learn?

Nothing surprising in retrospect, but worth noting: recursiveReadDirectory starts from the workspace root, not the theme root — so any large files anywhere in the repo are fair game without an explicit list.

Before you deploy

• I included a patch bump changeset

[graygilmore]

This makes sense. I'm going to just check with the team that we don't want to make any exceptions for files in the root directory.

[aswamy]

Thank you for your contribution @elia !

I would suggest one thing here. The current approach does work, but can still be costly if there are deeply nested files (like modules in your theme directory).

If we move this change to the recursiveReadDirectory function itself, we could prevent unnecessary reads of directories at the top-level of the recursive call.

e.g.

// context-utils.js

export async function recursiveReadDirectory(
  fs: AbstractFileSystem,
  uri: string,
  filter: (fileTuple: FileTuple) => boolean,
  directoryFilter?: (fileTuple: FileTuple) => boolean,
): Promise<UriString[]> {
  const allFiles = await fs.readDirectory(uri);
  const files = allFiles.filter(
    (ft) =>
      !isIgnored(ft) &&
      (isDirectory(ft) ? (directoryFilter ? directoryFilter(ft) : true) : filter(ft)),
  );

  const results = await Promise.all(
    files.map((ft) => {
      if (isDirectory(ft)) {
        // Only apply directoryFilter at the root level — once inside a theme
        // directory, recurse freely.
        return recursiveReadDirectory(fs, ft[0], filter);
      } else {
        return Promise.resolve([ft[0]]);
      }
    }),
  );

  return results.flat();
}

// DocumentManager.ts

const THEME_DIRS =
  /\/(assets|blocks|config|layout|locales|sections|snippets|templates)$/;
const filesToLoad = await recursiveReadDirectory(
  this.fs,
  rootUri,
  ([uri]) => /\.(liquid|json)$/.test(uri) && !this.sourceCodes.has(uri),
  ([uri]) => THEME_DIRS.test(uri),
);