[3.0] Enhance data handling and improve code readability#9191
Open
live627 wants to merge 17 commits intoSimpleMachines:release-3.0from
Open
[3.0] Enhance data handling and improve code readability#9191live627 wants to merge 17 commits intoSimpleMachines:release-3.0from
live627 wants to merge 17 commits intoSimpleMachines:release-3.0from
Conversation
Member
Sesquipedalian
requested changes
Apr 30, 2026
Comment on lines
+3885
to
+3898
|
|
||
| /** | ||
| * crc32 doesn't work as expected on 64-bit functions - make our own. | ||
| * https://php.net/crc32#79567 | ||
| * | ||
| * @param string $number | ||
| * @return string The crc32 | ||
| */ | ||
| private static function smf_crc32(string $number): string | ||
| { | ||
| require_once Config::canonicalPath(Config::$sourcedir . '/Subs-Compat.php'); | ||
|
|
||
| return smf_crc32($number); | ||
| } |
Member
There was a problem hiding this comment.
Why has this been brought back?
live627
commented
May 1, 2026
Co-authored-by: Jon Stovell <jonstovell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is focused on performance optimizations for package lists. Most changes focus on temporary string management and code readability.