Matter Switch: Support fan/light devices as parent/child #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 480 suites 0s ⏱️ Results for commit d291eb7. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d291eb7 |
This was referenced Dec 16, 2025
hcarter-775
force-pushed
the
support/fan-child-devices
branch
from
80239d5 to
fda9ae0
Compare
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Show resolved
Hide resolved
Comment on lines
+230
to
+271
| local fan_device_type_ep_ids = switch_utils.get_endpoints_by_device_type(device, fields.DEVICE_TYPE_ID.FAN) | ||
| if #fan_device_type_ep_ids > 0 then | ||
| updated_profile, optional_component_capabilities = FanDeviceConfiguration.assign_profile_for_fan_ep(device, default_endpoint_id) | ||
| device:set_field(fields.MODULAR_PROFILE_UPDATED, true) | ||
| end |
Contributor
There was a problem hiding this comment.
For now this is perfectly fine, but it might be worth discussing alternate approaches for the default endpoint logic at some point. Because at this point we already know the default endpoint contains a fan device type so it seems like we shouldn't need the get_endpoints_by_device_type call.
Contributor
|
One more thing I thought of - wasn't there a switch/fan device out there as well? Should we add support for that in this PR? |
Contributor
Author
|
@nickolas-deboom any WWST request would be done in a separate PR in my mind. Also, I believe that manufacturer re-tested the device with this current PR and liked the result, category and all |
hcarter-775
force-pushed
the
support/fan-child-devices
branch
from
a5ce6e0 to
bec20ae
Compare
nickolas-deboom
approved these changes
Jan 8, 2026
hcarter-775
force-pushed
the
support/fan-child-devices
branch
from
9fc4ae4 to
a33c57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add support for fan/light devices as parent/child
Summary of Completed Tests
Unit tests updated, tested on-device