Matter Switch: Add StatelessStep capability support for SwitchLevel and ColorTemperature #2677
Conversation
hcarter-775
requested review from
Kwang-Hui,
ctowns,
greens,
nickolas-deboom and
tpmanley
|
Duplicate profile check: Warning - duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 481 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 987716d. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 987716d |
| local endpoint_id = device:component_to_endpoint(cmd.component) | ||
| -- before the Matter 1.3 lua libs update (HUB FW 55), there was no ColorControl StepModeEnum type defined | ||
| local step_mode = step_percent_change > 0 and (clusters.ColorControl.types.StepModeEnum.DOWN or 3) or (clusters.ColorControl.types.StepModeEnum.UP or 1) | ||
| local min_mireds = switch_utils.get_field_for_endpoint(device, fields.COLOR_TEMP_BOUND_RECEIVED_MIRED..fields.COLOR_TEMP_MIN, endpoint_id) or 2200 -- default min mireds |
There was a problem hiding this comment.
The default value for min_mireds is 2200 which is a kelvin value instead of mired. Also, mired and kelvin have an inverse relationship so the default minimum mired should match the default maximum kelvin value.
| -- before the Matter 1.3 lua libs update (HUB FW 55), there was no ColorControl StepModeEnum type defined | ||
| local step_mode = step_percent_change > 0 and (clusters.ColorControl.types.StepModeEnum.DOWN or 3) or (clusters.ColorControl.types.StepModeEnum.UP or 1) |
There was a problem hiding this comment.
Given this comment, does this line need to be something like this?
| -- before the Matter 1.3 lua libs update (HUB FW 55), there was no ColorControl StepModeEnum type defined | |
| local step_mode = step_percent_change > 0 and (clusters.ColorControl.types.StepModeEnum.DOWN or 3) or (clusters.ColorControl.types.StepModeEnum.UP or 1) | |
| -- before the Matter 1.3 lua libs update (HUB FW 55), there was no ColorControl StepModeEnum type defined | |
| local step_mode = step_percent_change > 0 and (clusters.ColorControl.types.StepModeEnum and clusters.ColorControl.types.StepModeEnum.DOWN or 3) or (clusters.ColorControl.types.StepModeEnum and clusters.ColorControl.types.StepModeEnum.UP or 1) |
| @@ -0,0 +1,15 @@ | |||
| name: Stateless Color Temperature Step | |||
There was a problem hiding this comment.
These capabilities are available in the capabilities repo - can they be removed here?
There was a problem hiding this comment.
yeah, I think so.
Description of Change
Update all profiles to support statelessStep capabilities as needed. Include handlers for these step capabilities using the Matter-provided step commands.
This breaks apart the work found in #2669 so that the stateless capability support can be reviewed as an isolated unit.
Summary of Completed Tests
Unit tests added. Tested on-device.