Skip to content

add MultiIR Siren MIR-SR100#2873

Open
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_siren_MIR-SR100
Open

add MultiIR Siren MIR-SR100#2873
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_siren_MIR-SR100

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented Apr 3, 2026

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Test Results

   72 files    509 suites   0s ⏱️
2 819 tests 2 819 ✅ 0 💤 0 ❌
4 714 runs  4 714 ✅ 0 💤 0 ❌

Results for commit ef30a78.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/frient/init.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ef30a78

@thinkaName thinkaName force-pushed the multiir_siren_MIR-SR100 branch from 310380b to 45687a6 Compare April 29, 2026 02:54
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a couple style things, and one issue with handling nil preferences (which shouldnt happen, but the logic could pass a boolean rather than the default if it was nil).

Comment thread drivers/SmartThings/zigbee-siren/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-siren/src/test/test_multiir_zigbee_siren_tamper.lua Outdated
@thinkaName thinkaName force-pushed the multiir_siren_MIR-SR100 branch from 45687a6 to ef30a78 Compare May 7, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants