fix(pipewire): get core info for getting driver version#75
Open
mccadecortez wants to merge 1 commit intoSolarLiner:mainfrom
Open
fix(pipewire): get core info for getting driver version#75mccadecortez wants to merge 1 commit intoSolarLiner:mainfrom
mccadecortez wants to merge 1 commit intoSolarLiner:mainfrom
Conversation
SolarLiner
approved these changes
Jul 10, 2025
Owner
SolarLiner
left a comment
There was a problem hiding this comment.
Thanks for the PR and resolving the TODO for me!
Comment on lines
+98
to
+100
| let mainloop = MainLoop::new(None)?; | ||
| let context = Context::new(&mainloop)?; | ||
| let core = context.connect(None)?; |
Owner
There was a problem hiding this comment.
How does this behave when the user has already started to manipulate AudioDevices? It feels like pipewire is going to reject creating the loop and contexwt a second time. Maybe it's worth moving these to the driver itself, so that as long as people have a handle to the driver, it all works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Include relevant motivation and context.
Appends 384cda0, implements https://docs.pipewire.org/structpw__core__info.html for getting the pipewire version
Type of Change
How Has This Been Tested?
Checklist:
need to be validated manually (i.e. a new audio driver), use examples that can be run to easily validate them.
Screenshots (if appropriate):
Additional Notes: