Font#823
Closed
timea-solid wants to merge 89 commits into
Closed
Conversation
This has been implemented as a swappable interface to support other environments easily, and particularly in order to eventually converge on an interoperable system for all Web Component libraries in the Solid ecosystem
Prompt: We're using the tailwindcss preflight resets in @src/primitives/styles/common.styles.css, but they have an overly aggressive selector that resets the margin and padding of any element. This is a problem because styling web component elements using :host in their own styles take less precedence in the situations were nested components are rendered. Use the patch-package utility to modify the built-in preflight and remove the padding and margin resets in the * selector. Instead, create a new rule that only resets padding and margin for built-in elements. Summary of Changes: 1. Modified Preflight Styles: Updated preflight.css to: • Remove margin: 0; and padding: 0; from the universal * selector rule. • Create a new rule resetting margins and paddings only for standard built-in HTML tags and pseudo-elements (such as ::after , ::before , ::backdrop , ::file-selector-button ). 2. Generated Patch: Ran npx patch-package tailwindcss to generate the patch file at tailwindcss+4.3.0.patch. 3. Staged and Verified: • Verified that npm run typecheck && npm run build and npm run test compile and pass without issues. • Staged the patch file along with the formatting tweak in package.json. Co-Authored-By: Antigravity CLI (Gemini 3.5 Flash) <bot@antigravity.local>
Implement a generic dialog system, see https://noeldemartin.com/blog/the-problems-with-modals-and-how-to-solve-them
…count #769 Update account components in header
…out endpoints 1. derive header auth state from auth session checks/events 2. call end_session and NSS well-known logout on logout 3. add/update header tests for session-driven state transitions
… fall back to node_modules so CI/standalone clones work.
… callback loops add guarded OIDC callback bootstrap in solid-ui loginStatusBox trigger authn.checkUser only when callback params are present keep login flow stable by not stripping callback params during bootstrap sanitize code/state/iss only in logout handler before reload avoid stale callback URL causing re-entry into provider selection after logout
…d logout callback loops" This reverts commit e04a7e7.
fix(auth): decouple SolidAuth from widget import chain and complete UVDSL session migration Body: complete UVDSL auth contract migration in the design-system auth adapter: use session root fields for state resolution (webId / isActive) keep compatibility fallback to legacy info fields during transition switch login call to positional signature (issuer, redirectUrl) switch session updates to EventTarget sessionStateChange with legacy events fallback remove transitive dependency on the heavy widget stack from auth bootstrap path: stop importing avatar lookup from widgets/buttons in auth adapter add a lightweight local avatar resolver using RDF predicates already used elsewhere fix test bootstrap regression where importing auth pulled in people picker and touched solidLogicSingleton.store too early under Jest preserve existing login UX behavior: keep loginIssuer and preLoginRedirectHash persistence keep authorization metadata reset before login redirect
Only 0.01% of our target browsers don't support it (KaiOS and Opera Mini), so it's not worth adding any polyfills. However, these changes make it at least usable on these browsers given that a <dialog> will be rendered as a plain unknown element instead of crashing.
Prompts: - Looking at https://github.com/shoelace-style/webawesome/blob/next/packages/webawesome/src/components/select/select.ts, can you update the Combobox component to be accessible? Also, replace the popup and anchor CSS positioning by using Web Awesome's popup instead (wa-popup). - Can you review the ARIA guidelines for our current implementation? https://www.w3.org/WAI/ARIA/apg/patterns/combobox/ AI Summary of the work: - Replaced native popover and CSS anchor positioning with wa-popup - Added combobox ARIA roles, states, and keyboard navigation - Aligned aria-selected, labeling, and keyboard behavior with APG guidelines - Close popup on outside click or focus, Escape, Tab, and empty filter results - Added label ids in InputTrait for aria-labelledby Co-Authored-By: Cursor <cursoragent@cursor.com>
#772 Improve Browser Support for new components
…istry@3.1.2-1) (latest: rdflib@2.4.0)
…istry@3.1.2-1) (latest: rdflib@2.4.0)
Fix dev v3.1.3-7
…istry@3.1.2-1) (latest: rdflib@2.4.0)
remove duplicate load of button component and other v2 components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added Atkinsons. For now we load it from Google. We need to test if there is latency added.