Conversation
NoelDeMartin
left a comment
NoelDeMartin
left a comment
There was a problem hiding this comment.
This can work for now, and maybe we could even release it like this... But we should discuss whether we want to add a dependency with google for the fonts. People using Solid will be particularly privacy-sensitive, so I don't know if they'll like seeing that every time they open SolidOS, they'll be pinging google's servers.
As per the web awesome fonts variables, I think it should be fine to simply define --wa-font-family-body as well. See their theming docs.
|
Consider also merging SolidOS/mashlib#441 (non blocking) |
NoelDeMartin
left a comment
NoelDeMartin
left a comment
There was a problem hiding this comment.
As I mentioned, I'm ok with merging this as is... but before releasing a new version, we should double-check if we really want to be injecting Google's CDN into SolidOS.
3 participants
I added the font for now here.
However, it seems like it is overwritten by the --wa-font-family-body: ui-sans-serif, system-ui, sans-serif;
I also need to delete the font in mashlib light.css.