make an "add as friend" web component#826
Open
SharonStrats wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new solid-ui-button-add-friend web component by extracting the “add as friend” behavior into a reusable component, along with supporting helpers, styling, and a Storybook story.
Changes:
- Added
ButtonAddFriendweb component that checks login state, detects existing friendships, and performs the FOAFknowsmutation. - Added helper to ensure standard RDF prefixes are registered for rdflib mutations.
- Added component styling and a Storybook story for basic states.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/button-add-friend/index.ts | Barrel export for the new add-friend component. |
| src/components/button-add-friend/helpers.ts | Adds prefix-registration helper used before rdflib updates. |
| src/components/button-add-friend/ButtonAddFriend.ts | Implements the add-friend web component and mutation logic. |
| src/components/button-add-friend/ButtonAddFriend.styles.css | Styles the inline status banner shown on error. |
| src/components/button-add-friend/ButtonAddFriend.stories.ts | Storybook coverage for guest/logged-in/friend-exists states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SharonStrats
force-pushed
the
feat/add-friends-component
branch
2 times, most recently
from
2253b1e to
69ec36f
Compare
SharonStrats
force-pushed
the
feat/add-friends-component
branch
from
69ec36f to
ab67365
Compare
Prompt: Create stories for ButtonAddFriend for guest, loggedin and FriendExists follow the stories in the Component directory Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
Member
|
Looks ok to me, but I would appreciate Noels review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves over the code from profile-pane for adding as a friend and creates a Web Component from the code.