solid-ui themes foundation #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a theme foundation for solid-ui by adding CSS custom properties (CSS variables) support for styling, while updating dependencies to a prerelease version of solid-ui. It also includes a minor fix changing a const to let declaration.
Changes:
- Updates solid-ui to prerelease version
3.0.1-11be53bwith theme support - Adds CSS custom properties (
--sui-space-lg,--sui-border-color,--sui-border-radius) with fallback values in sourcePane styling - Fixes variable declaration from
consttoletfor theposvariable that is reassigned
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/sourcePane.js | Adds theme variable support with CSS custom properties and fallbacks; changes pos from const to let |
| package.json | Updates solid-ui peer and dev dependencies to prerelease version; adds pane-registry dev dependency |
| package-lock.json | Updates dependency lockfile to reflect package.json changes |
| eslint.config.mjs | Contains unresolved merge conflict that must be fixed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.