Skip to content

SONARJAVA-5961 Upgrade sonar-java-jdt to 1.8.0.1483 #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasz-tylenda-sonarsource merged 6 commits into from
Jan 29, 2026
Merged

SONARJAVA-5961 Upgrade sonar-java-jdt to 1.8.0.1483 #5388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
464c063
Use sonar-java-jdt 1.8
tomasz-tylenda-sonarsource Jan 19, 2026
d262976
fix testSpringBootAssertableApplicationContext
tomasz-tylenda-sonarsource Jan 20, 2026
9f46a0e
Change eclipse-jetty S1905 ground truth
tomasz-tylenda-sonarsource Jan 20, 2026
f23c204
Review round 1
tomasz-tylenda-sonarsource Jan 27, 2026
57c2907
QG
tomasz-tylenda-sonarsource Jan 27, 2026
8959b1b
bring back empty line
tomasz-tylenda-sonarsource Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S1905.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/Cookies.java": [
102
],
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java": [
279
],
Expand Down
3 changes: 0 additions & 3 deletions its/ruling/src/test/resources/eclipse-jetty/java-S1905.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/Cookies.java": [
102
],
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java": [
279
],
Expand Down
3 changes: 2 additions & 1 deletion java-checks-test-sources/default/src/main/java/checks/RedundantTypeCastCheckSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ <K> K getValue(K s) {
return s;
}
String foo() {
return (String) getValue(""); // Noncompliant
// FN introduced due to ECJ 3.44
return (String) getValue(""); // Compliant
}
}

Expand Down
11 changes: 8 additions & 3 deletions java-checks/src/main/java/org/sonar/java/checks/tests/AssertionsInTestsCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,18 @@ private boolean isSpringBootAssertableContext(MethodTree methodTree) {
// In this case we cannot know if the provided ContextConsumer has the type param <AssertableApplicationContext>, but we want to avoid FPs
return true;
}
Type contextConsumerType;
Type contextConsumerType = null;
if (contextConsumerImplSymbol.isInterface()) {
contextConsumerType = contextConsumerImplSymbol.type();
} else {
contextConsumerType = contextConsumerImplSymbol.interfaces().get(0);
List<Type> interfaces = contextConsumerImplSymbol.interfaces();
if (!interfaces.isEmpty()) {
contextConsumerType = interfaces.get(0);
}
}
return isAssertableApplicationContext(contextConsumerType) && hasDeclaredAssertions(contextConsumerImplSymbol);
return contextConsumerType != null
&& isAssertableApplicationContext(contextConsumerType)
&& hasDeclaredAssertions(contextConsumerImplSymbol);
}
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion java-frontend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>jdt-package</artifactId>
<version>1.6.0.160</version>
<version>1.8.0.1483</version>
</dependency>

<dependency>
Expand Down
2 changes: 1 addition & 1 deletion java-frontend/src/test/java/org/sonar/java/model/JParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ void foo() {}

Token token5 = tokens.get(5);
assertThat(token5.toString(source)).isEqualTo("/// markdown comment 1\n /// markdown comment 2");
assertThat(token5.isComment()).isFalse(); // JDT issue https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3914
assertThat(token5.isComment()).isTrue();
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

assertThat(isComment(token5)).isTrue();
assertThat(convertTokenTypeToCommentKind(token5)).isEqualTo(CommentKind.MARKDOWN);

Expand Down
Loading