Centralize add_segment and segments to BaseExtractor#4462
Open
alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
Open
Centralize add_segment and segments to BaseExtractor#4462alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
add_segment and segments to BaseExtractor#4462alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
Conversation
This was referenced Mar 23, 2026
h-mayorquin
reviewed
Mar 24, 2026
| # we remove the annotation if it exists | ||
| _ = self._annotations.pop("name", None) | ||
|
|
||
| @property |
Collaborator
There was a problem hiding this comment.
Maybe for typing we could in BaseRecording for example:
@property
def segments(self) -> list[BaseRecordingSegment]:
return self._segments # type: ignore[return-value]As that will enable the analysis of base recording sgements methods that we call on introspection with vscode and ohter tools. Same for bas sorting.
Collaborator
There was a problem hiding this comment.
Also, can we make this private? what is the reason for making this public?
| mode: "extremum" | "at_index" | "peak_to_peak" = "extremum", | ||
| peak_sign: Literal["neg", "pos", "both"] = "neg", | ||
| mode: Literal["extremum", "at_index", "peak_to_peak"] = "extremum", | ||
| operator: Literal["average", "median"] = "average", |
Member
Author
There was a problem hiding this comment.
because of typing errors...
Member
|
I think I was more happy with the private approach And as @h-mayorquin So ok for merging. @chrishalcrow : did you check this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix a bunch of typing errors
Pulled out of #4216