Portal fix and glow keyvalues - #346
Merged
Merged
Conversation
this entity inherits all the keyvalues from prop_dynamic, so the only different keyvalue it should have is enabling glow by default
the existance of the glowstyle kv means that it's not always visible through walls
Member
|
For the glow keys, they should probably be moved to a base class, not copy-pasted to both. |
TeamSpen210
previously approved these changes
Aug 5, 2026
TeamSpen210
approved these changes
Aug 5, 2026
TeamSpen210
enabled auto-merge (rebase)
August 5, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue of a bounding box enveloping prop_portal inherited from #308, while also adding keyvalues and i/o for the hidden glow mechanic BaseEntityAnimating and BaseEntityPhysics have. Both of these have been tested on my end in the latest staging branch, and seem to be functional.