Fix hidden column reset when inbox count changes

[shervElmi]

Fixes https://github.com/Strategy11/formidable-pro/issues/5794

This PR fixes an issue where hidden column preferences reset when the inbox unread count changes.

Pro PR

• https://github.com/Strategy11/formidable-pro/pull/6189

Summary by CodeRabbit

• Refactor

  • Improved menu badge handling and display logic in admin interface
  • Simplified dashboard and entries screen options filter registration
  • Standardized filter hook naming patterns across controllers

• Deprecation

  • Deprecated unread inbox count retrieval helper method

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c3290d3e-070a-4963-84b2-76acf9b658f4

📥 Commits

Reviewing files that changed from the base of the PR and between 10d5cae and 5f217d5.

📒 Files selected for processing (4)

• classes/controllers/FrmAppController.php
• classes/controllers/FrmDashboardController.php
• classes/controllers/FrmEntriesController.php
• classes/helpers/FrmEntriesHelper.php

🚧 Files skipped from review as they are similar to previous changes (2)

• classes/controllers/FrmDashboardController.php
• classes/helpers/FrmEntriesHelper.php

---

📝 Walkthrough

Walkthrough

Centralizes admin menu badge logic into FrmAppController::add_menu_badge(), removes dynamic unread-count suffixes from hook/screen identifiers in dashboard, entries, and payments controllers, and deprecates FrmEntriesHelper::get_visible_unread_inbox_count() which now returns 0.

Changes

Menu badge centralization and suffix removal

Layer / File(s)	Summary
Centralize menu badge classes/controllers/FrmAppController.php	Added public static function add_menu_badge() and updated menu() to call it after adding the admin menu item; badge lookup and global $menu mutation moved into the helper.
Dashboard hook key staticization classes/controllers/FrmDashboardController.php	Dashboard columns filter now registers as manage_<menu_name>_page_formidable-dashboard_columns without an unread-count suffix.
Entries screen & column key classes/controllers/FrmEntriesController.php	Removed unread-count suffix from remove_screen_options() screen id comparison and from base_column_key(); remove_screen_options() now returns $show_screen when appropriate.
Deprecated unread-count helper classes/helpers/FrmEntriesHelper.php	get_visible_unread_inbox_count() marked @deprecated, now calls _deprecated_function() and returns 0.
Payments hooks/screen options stripe/controllers/FrmTransLiteListsController.php	Removed unread-count suffix from payments columns hook name and screen-option comparisons; hook names use sanitized menu name only. (change summarized from PR metadata)

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fix missing latest entries on dashboard #2214: Adds dynamic unread-count logic previously used by menu badges.
• Include count on Formidble menu item #2193: Related badge append refactor.
• Fix payments lists empty when inbox count is displayed #2221: Related changes to unread-count-based hook/screen-name construction.

Suggested labels

action: needs qa

Suggested reviewers

• Crabcyborg

"A rabbit's note on menus, shiny and bright,
I hopped through code in the quiet night.
Badges now tidy, suffixes gone—hip hooray! 🥕
I twitched my nose and hopped away,
Leaving menus neat for the morning light."

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix hidden column reset when inbox count changes' accurately describes the core issue being resolved in the PR—stabilizing screen IDs so hidden column preferences persist when inbox counts change.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/hidden-columns-stable-screen-id

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Crabcyborg]

I think this should be good.

We'll likely lose some settings for people who were at a certain inbox number, but it's probably not worth any extra work trying to pull the last setting they had.

🚀

[Crabcyborg]

Actually, I'm going to hold it here.

It looks like get_visible_unread_inbox_count is also called in the coupons add-on.

[deepsource-io]

DeepSource Code Review

We reviewed changes in 0c23257...5f217d5 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Jun 3, 2026 3:57p.m.	Review ↗
JavaScript		Jun 3, 2026 3:57p.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.