Make the cloud web client buildable - #130
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis change prepares Icarus for browser use by isolating Windows-only startup work, adding a release web build to CI, and updating browser beta messaging and metadata. Browser-target execution confirmed that deep-link registration, single-instance handling, and desktop window setup resolve to web-safe implementations. A Linux execution harness also confirmed that non-Windows deep-link registration exits before reaching Windows Registry operations. T-Rex validation blockedDirect sign-out toast and WebView warm-up tests, along with the complete Flutter web build, could not finish because Confidence Score: 4/5The reviewed platform-isolation changes behave safely in the executed browser-target and Linux-native checks. Focused execution proved web startup avoids native desktop operations and Linux registration avoids Registry access. Complete browser startup, direct toast-failure handling, and direct WebView warm-up state assertions remain unexecuted because dependency compilation fails before the test bodies run. Files Needing Attention: Before merging, validate
What T-Rex did
Reviews (1): Last reviewed commit: "Make the cloud web client buildable" | Re-trigger Greptile |
The browser client was not a usable second beta client: the web compiler reached Windows-only FFI imports and failed before Icarus could load.
This PR:
Verification:
The authenticated two-client edit/join proof still needs a beta account in the browser. No credentials were created or copied as part of this PR.