use target_compile_definitions to build backend within another project #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you include this cmake project as a "subproject" of another project, CMake complains in Windows (MSVC) that it cannot find
M_PIbecause-D_USE_MATH_DEFINESis not defined. (Actually it does something really funky if I add#define _USE_MATH_DEFINESto the source files. The compiler complains that_USE_MATH_DEFINEShas already been defined despite it's not.)Anyway, this PR fixes this issue by using per-project
target_compile_definitionscmake command instead ofadd_definition.