feat(connections): add cross-connection object search - #2098
Open
sophiathedev wants to merge 3 commits into
Open
feat(connections): add cross-connection object search#2098sophiathedev wants to merge 3 commits into
sophiathedev wants to merge 3 commits into
Conversation
sophiathedev
force-pushed
the
feat/cross-conn-obj-search
branch
from
August 12, 2026 06:26
e2c63ba to
a8b0095
Compare
sophiathedev
marked this pull request as ready for review
August 12, 2026 06:29
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8b0095499
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Connections scope to Quick Switcher so tables, views, and system tables can be found across every connected TablePro window.
What you get
Open Quick Switcher with
Cmd+Shift+O, then select Connections or pressCmd+5. Results are grouped by connection and include the database and schema path. Search matches both the object name and that path, so a connection name can narrow the list.Returnopens the object in its owning connection and brings that window forward.Option+Returnopens it in a new native window tab. A singleEscapealways dismisses the panel, including when the search field contains text.Scope and loading
Cross-connection catalogs load only when the Connections scope is opened. TablePro reuses an already-loaded schema when possible and otherwise loads the database or schema currently being browsed by each connected session. Results refresh when connection status changes.
The scope intentionally searches connected windows only. It does not connect saved but inactive connections or crawl every database and schema on a server.
Safety around stale results
Each result carries its connection, database, and schema target. Catalog loading uses cancellation and load identifiers so an older task cannot replace newer results. Before accepting loaded objects, the view model verifies that the session is still connected and still browsing the same database and schema.
Opening a result reuses an active coordinator only when its live context still matches the target. Otherwise the request goes through
TabRouter; routing failures are surfaced in an error sheet instead of opening the object in the wrong connection.Tests
QuickSwitcherViewModelTests,QuickSwitcherFrecencyStoreTests,QuickSwitcherPanelControllerTests, andQuickSwitcherSearchFieldTests: TEST SUCCEEDED.xcodebuild build-for-testing, includingQuickSwitcherCrossConnectionUITests: BUILD SUCCEEDED.swiftlint lint --strict --quiet: clean.Option+Return, native window tabs, and one-pressEscapeall passed.Automated XCUITest execution was unavailable locally because the machine has no development signing profile. The UI test target compiled, and the same flow was verified manually. The aggregate
TableProTestsrun still has unrelated shared-state and network-fixture failures; the Quick Switcher suites pass in isolation.