Skip to content

feat(connections): add cross-connection object search - #2098

Open
sophiathedev wants to merge 3 commits into
TableProApp:mainfrom
sophiathedev:feat/cross-conn-obj-search
Open

feat(connections): add cross-connection object search#2098
sophiathedev wants to merge 3 commits into
TableProApp:mainfrom
sophiathedev:feat/cross-conn-obj-search

Conversation

@sophiathedev

Copy link
Copy Markdown

Adds a Connections scope to Quick Switcher so tables, views, and system tables can be found across every connected TablePro window.

What you get

Open Quick Switcher with Cmd+Shift+O, then select Connections or press Cmd+5. Results are grouped by connection and include the database and schema path. Search matches both the object name and that path, so a connection name can narrow the list.

Return opens the object in its owning connection and brings that window forward. Option+Return opens it in a new native window tab. A single Escape always dismisses the panel, including when the search field contains text.

Scope and loading

Cross-connection catalogs load only when the Connections scope is opened. TablePro reuses an already-loaded schema when possible and otherwise loads the database or schema currently being browsed by each connected session. Results refresh when connection status changes.

The scope intentionally searches connected windows only. It does not connect saved but inactive connections or crawl every database and schema on a server.

Safety around stale results

Each result carries its connection, database, and schema target. Catalog loading uses cancellation and load identifiers so an older task cannot replace newer results. Before accepting loaded objects, the view model verifies that the session is still connected and still browsing the same database and schema.

Opening a result reuses an active coordinator only when its live context still matches the target. Otherwise the request goes through TabRouter; routing failures are surfaced in an error sheet instead of opening the object in the wrong connection.

Tests

  • Focused QuickSwitcherViewModelTests, QuickSwitcherFrecencyStoreTests, QuickSwitcherPanelControllerTests, and QuickSwitcherSearchFieldTests: TEST SUCCEEDED.
  • xcodebuild build-for-testing, including QuickSwitcherCrossConnectionUITests: BUILD SUCCEEDED.
  • swiftlint lint --strict --quiet: clean.
  • Manual macOS flow with the Chinook sample: cross-connection search, no-result state, result opening, Option+Return, native window tabs, and one-press Escape all passed.

Automated XCUITest execution was unavailable locally because the machine has no development signing profile. The UI test target compiled, and the same flow was verified manually. The aggregate TableProTests run still has unrelated shared-state and network-fixture failures; the Quick Switcher suites pass in isolation.

@sophiathedev
sophiathedev force-pushed the feat/cross-conn-obj-search branch from e2c63ba to a8b0095 Compare August 12, 2026 06:26
@sophiathedev
sophiathedev marked this pull request as ready for review August 12, 2026 06:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8b0095499

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread TablePro/ViewModels/QuickSwitcherViewModel.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant