feat(theme): support system light and dark themes - #651
Conversation
Add persisted light and dark theme mappings with optional system appearance tracking. Expose the mappings in Appearance settings and keep the SQL editor's Same as App mode synchronized.\n\nCloses TabularisDB#649
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
The change adds persisted Reviewed by glm-5.2 · Input: 27.7K · Output: 6.5K · Cached: 224.8K |
|
Thanks a lot for this, and sorry for the timing overlap: #650 was opened by the issue author a few minutes before yours and lands the same config fields and mode switch, plus the native window chrome sync via Tauri setTheme (the Linux/GNOME CSD case discussed in #649), all 11 locales and test coverage. I've merged that one and I'm closing this to avoid two parallel implementations of the same feature. Two things from your PR I'd genuinely like to see as follow-ups if you're up for it:
Happy to review either quickly. |
Summary
prefers-color-schemeSame as AppsynchronizationCloses #649
Validation
pnpm typecheckpnpm lintpnpm buildcargo check --manifest-path src-tauri/Cargo.tomlgit diff --checkThe repository-wide
cargo fmt --checkcurrently reports unrelated pre-existing formatting differences outside this change.