fix(start): prebundle client RPC dependencies - #8384
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe client Vite environment now prebundles ChangesClient dependency optimization
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The supplied change introduces no verified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version Preview4 package(s) bumped directly, 20 bumped as dependents. 🟩 Patch bumps
|
|
View your CI Pipeline Execution ↗ for commit 9763973
☁️ Nx Cloud last updated this comment at |
Bundle Size BenchmarksThis pull request does not affect bundle size in any measured scenario. |
🎯 Changes
Prebundle the client RPC dependencies that Start's transforms introduce after Vite's initial scan. A clean first visit to the Form example discovered these dependencies during rendering, reoptimized them, and loaded different React module instances. The page logged invalid-hook-call errors before recovering through a reload.
Add the existing serialization and cookie dependencies to the client optimizer using their framework-owned dependency paths. Server optimization and production bundling are unchanged. No example-specific override is needed.
The companion regression in #8376 forces a cold dependency scan and fails on hook errors logged through React's boundary. It fails against the original framework and passes with this change. That PR must include this fix before merging.
Validation:
✅ Checklist
🚀 Release Impact
Summary by CodeRabbit