fix: align grouped sticky headers - #6472
Open
biubiukam wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe sticky column-pinning example now supports grouped headers. It derives pinning styles from visible leaf columns, adds an ChangesGrouped header sticky pinning
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant HeaderCell
participant getHeaderPinningStyles
participant getCommonPinningStyles
HeaderCell->>getHeaderPinningStyles: pass grouped header
getHeaderPinningStyles->>getHeaderPinningStyles: find visible leaf columns
getHeaderPinningStyles->>getCommonPinningStyles: pass leaf boundaries and pin position
getCommonPinningStyles-->>HeaderCell: return sticky styles
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
biubiukam
marked this pull request as ready for review
July 31, 2026 06:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fix grouped sticky headers in the React column pinning example.
Grouped headers now derive their sticky side, offsets, width, and boundary shadow from the leaf columns rendered by the current header segment. This keeps mixed partial-pinning segments relative and aligns fully pinned groups when other pinned columns precede or follow them.
Add Playwright coverage for partial group pinning and non-zero start/end offsets.
Fixes #5397
✅ Checklist
pnpm test:pr.Summary by CodeRabbit
New Features
Tests