Fix docs title during loader failures - #1223
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 6fe99d7 | Commit Preview URL Branch Preview URL |
Sep 05 2026, 03:08 PM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe docs route now avoids rendering ChangesSEO title fallback
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Documentation pages now show a meaningful library Docs title during loader failures while retaining existing titles for successful loads. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Evidence
Issue #1219 shows
undefined | TanStack Router Docswhile a connectivity failure triggers the route error UI. The generic docs route interpolates the optional loader title into a template string, which converts a missing value into the literal wordundefined.Impact
Connectivity and other transient loader failures now keep a useful title such as
TanStack Router Docs. Successful document loads keep their existing title.Validation
pnpm testpassed twice, including the commit hook: TypeScript and type-aware lint are clean, 479 tests total, 478 passed, and 1 environment-gated docs smoke test skipped.git diff --checkpassed.Risk
Very low. This changes one metadata fallback and does not affect successful loader output.
Closes #1219
Summary by CodeRabbit