Skip to content

test(marko-virtual): mark chat "Latest" e2e as fixme pending #1267 - #1278

Merged
piecyk merged 1 commit into
TanStack:mainfrom
piecyk:damian/fix/marko-chat-latest-fixme
Sep 11, 2026
Merged

test(marko-virtual): mark chat "Latest" e2e as fixme pending #1267#1278
piecyk merged 1 commit into
TanStack:mainfrom
piecyk:damian/fix/marko-chat-latest-fixme

Conversation

@piecyk

@piecyk piecyk commented Sep 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

The plain chat spec's "Latest returns to the bottom and status flips back to At latest" hits the same prepend race that #1268 disabled in the chat-pretext spec, and it is failing CI on unrelated PRs (#1248, #1272). Latest is clicked while the near-top auto history load is in flight; the prepend resolves after the jump and the adapter's anchor write is clamped against the not-yet-grown sizer, so the status stays "Reading history".

🎯 Changes

Re-enable once #1267 is fixed (#1273).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests

    • Temporarily skipped an intermittently failing chat navigation test in continuous integration.
    • Added tracking context for a race condition affecting the “Latest” status while older messages are loading.

  • User Impact

    • No user-facing functionality or behavior changes are included in this update.

@piecyk @claude
test(marko-virtual): mark chat "Latest" e2e as fixme pending TanStack…
350e73e 
…#1267

Same prepend race TanStack#1268 disabled in the chat-pretext spec, still enabled in
the plain chat spec and failing on CI for unrelated PRs (TanStack#1248, TanStack#1272).
Re-enable once TanStack#1267 is fixed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1777d858-084b-4d22-a0ef-e8e7f41db0f7

📥 Commits

Reviewing files that changed from the base of the PR and between df47889 and 350e73e.

📒 Files selected for processing (1)
  • packages/marko-virtual/e2e/app/e2e/chat.spec.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The chat end-to-end test for returning to the latest messages is now skipped with test.fixme. A FIXME comment documents a CI race involving history prepending and anchor positioning.

Changes

Chat history test handling

Layer / File(s) Summary
Skip and document the flaky test
packages/marko-virtual/e2e/app/e2e/chat.spec.ts		 The test now uses test.fixme. The comment describes the prepend race and the resulting Reading history status.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 350e7

This change has no release impact and is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the change: marking the Marko Virtual chat end-to-end test as fixme pending issue #1267.
Description check ✅ Passed The description explains the flaky prepend race, identifies the affected test, describes the fix, references the tracking issue, and completes all required template sections and checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 350e73e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 5s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-11 15:48:57 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@1278

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@1278

@tanstack/marko-virtual

npm i https://pkg.pr.new/@tanstack/marko-virtual@1278

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@1278

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@1278

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@1278

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@1278

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@1278

commit: 350e73e

@piecyk
piecyk merged commit 9151094 into TanStack:main Sep 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@piecyk