feat: Onboarding Welcome Page - #2435
Merged
Merged
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Jun 18, 2026
Collaborator
Author
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
June 19, 2026 01:39
be1cab9 to
475b1de
Compare
camielvs
changed the base branch from
06-17-feat_onboarding_checklist
to
graphite-base/2435
June 19, 2026 01:46
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 19, 2026 01:46
475b1de to
b2ef001
Compare
camielvs
changed the base branch from
graphite-base/2435
to
06-18-feat_onboarding_pill
June 19, 2026 01:46
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 19, 2026 02:09
33d4a5c to
c38d713
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 19, 2026 02:09
b2ef001 to
46b33cb
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 19, 2026 02:25
c38d713 to
5f5d39b
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
June 19, 2026 15:43
4833c25 to
a93cf71
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 19, 2026 15:43
5f5d39b to
c994062
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 19, 2026 15:44
a93cf71 to
e0ce7f1
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
2 times, most recently
from
June 19, 2026 15:51
bbdf96e to
5ea2aaa
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 19, 2026 15:51
e0ce7f1 to
8c45c84
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 17:20
9daead8 to
25a3375
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 17:22
8cdc3b4 to
e396a7e
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 17:22
25a3375 to
274bf7f
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 19:28
e396a7e to
9e53492
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 19:28
274bf7f to
9096703
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 19:49
9e53492 to
dc15573
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
2 times, most recently
from
June 26, 2026 20:52
733a175 to
9dea09e
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
June 26, 2026 21:10
74401d4 to
75d35ae
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 21:10
9dea09e to
2b92751
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 21:13
75d35ae to
2a27cb9
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 21:13
2b92751 to
2404644
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 21:28
2a27cb9 to
d0c8019
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 21:28
2404644 to
714eabd
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 21:29
d0c8019 to
c47e06f
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 21:29
714eabd to
50a2381
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 21:30
c47e06f to
b04af07
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
June 26, 2026 21:30
50a2381 to
23e92c7
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
June 26, 2026 21:50
b04af07 to
6e26b09
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
2 times, most recently
from
June 26, 2026 22:00
1a96436 to
6a73580
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
June 26, 2026 23:01
0203fac to
1e17352
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
2 times, most recently
from
June 26, 2026 23:25
193c890 to
c296a9f
Compare
Collaborator
Author
- Gate OnboardingWelcome on !isReady with a spinner (match IndexRedirect) - Import APP_ROUTES from appRoutes instead of the router shim Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Final PR in the onboarding series (stacked on #2440). Gives new users a dedicated landing experience instead of dropping them into an empty dashboard.
/welcomeroute — a focused, centered welcome page hosting the onboarding card, so onboarding doesn't take over the "My Dashboard" view.IndexRedirect) —/now resolves based on onboarding state: new users (onboarding not complete and not dismissed) go to/welcome; everyone else goes to/dashboard. The dashboard is moved off/to its own route so manual navigation to either still works.isResolvedto avoid flicker.Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/622
Stacked on #2421 → #2440
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
/— you should be redirected to/welcomewith the onboarding card centered in the available space./— you should land on/dashboard./welcomeand/dashboard— both should be reachable regardless of redirect logic./welcomeand confirm subsequent visits to/land on the dashboard.Additional Comments
Routing decisions wait on
isReady(queries settled, valid even with no backend) while the sidebar entry gates onisResolved, matching the provider contract introduced earlier in the stack.