Skip to content

chore: v2 - sync behavior to validation fix resolution - #2590

Merged
maxy-shpfy merged 1 commit into
masterfrom
07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution
Jul 30, 2026
Merged

chore: v2 - sync behavior to validation fix resolution#2590
maxy-shpfy merged 1 commit into
masterfrom
07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Description

The MissingPipelineInputValueResolution component has been updated to set a pipeline input's value directly rather than its default value. The effective value displayed and edited is now derived from input.value ?? input.defaultValue, prioritizing an explicitly set value over the default. The label and UI copy have been updated from "Default value" to "Value", and a "Use as default" indicator (with a checkbox icon) has been added to the label row to communicate intent to the user.

Screenshots (if applicable)

image.png

Test Instructions

  1. Open a pipeline in the editor that has a missing pipeline input value issue.
  2. Verify the resolution panel displays "Set a value for pipeline input" with a "Value" label and a "Use as default" indicator.
  3. Enter a value and confirm it is saved as the input's value (not the default value).
  4. Verify that if an explicit value already exists, it takes precedence over the default value in the text area.

Additional Comments

The ioActions.setInputValue call replaces the previous ioActions.setInputDefaultValue call, so any downstream handling of input values vs. default values should be verified to ensure compatibility.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution/24818e4

maxy-shpfy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@maxy-shpfy
maxy-shpfy force-pushed the 07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution branch from 6edb0bf to c1e8ed9 Compare July 29, 2026 18:58
@maxy-shpfy
maxy-shpfy force-pushed the 07-29-fix_v2_-_support_value_and_default_in_input_nodes branch from f1f49e1 to 1b7b798 Compare July 29, 2026 18:58
@maxy-shpfy
maxy-shpfy marked this pull request as ready for review July 29, 2026 19:42
@maxy-shpfy
maxy-shpfy requested a review from a team as a code owner July 29, 2026 19:42

maxy-shpfy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 30, 5:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 30, 5:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 30, 5:22 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy
maxy-shpfy changed the base branch from 07-29-fix_v2_-_support_value_and_default_in_input_nodes to graphite-base/2590 July 30, 2026 17:10
@maxy-shpfy
maxy-shpfy changed the base branch from graphite-base/2590 to master July 30, 2026 17:16
@maxy-shpfy
maxy-shpfy force-pushed the 07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution branch from c1e8ed9 to 24818e4 Compare July 30, 2026 17:17
@maxy-shpfy
maxy-shpfy merged commit e9d694f into master Jul 30, 2026
16 checks passed
@maxy-shpfy
maxy-shpfy deleted the 07-29-chore_v2_-_sync_behavior_to_validation_fix_resolution branch July 30, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants