fix: raise ValueError for zero input in binary_count_trailing_zeros#14796
Closed
kasc0206 wants to merge 1 commit into
Closed
fix: raise ValueError for zero input in binary_count_trailing_zeros#14796kasc0206 wants to merge 1 commit into
kasc0206 wants to merge 1 commit into
Conversation
The function previously returned 0 for a == 0, but mathematically the number of trailing zeros in the binary representation of 0 is undefined (infinite). Now raises ValueError with a clear message. Fixes TheAlgorithms#14479
Closing this pull request as invalid@kasc0206, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14479
The
binary_count_trailing_zerosfunction previously returned0for inputa == 0, but mathematically the number of trailing zeros in the binary representation of 0 is undefined (infinite). Returning0was misleading and could cause bugs in algorithms relying on correct trailing zero counts.Changes
if a < 0toif a <= 0to catch zero input0 if (a == 0) elseternary fallbackbinary_count_trailing_zeros(0)to expectValueError'<'to'<='Verification