Skip to content

fix: raise ValueError for zero input in binary_count_trailing_zeros#14796

Closed
kasc0206 wants to merge 1 commit into
TheAlgorithms:masterfrom
kasc0206:fix/zero-trailing-zeros
Closed

fix: raise ValueError for zero input in binary_count_trailing_zeros#14796
kasc0206 wants to merge 1 commit into
TheAlgorithms:masterfrom
kasc0206:fix/zero-trailing-zeros

Conversation

@kasc0206

Copy link
Copy Markdown

Description

Fixes #14479

The binary_count_trailing_zeros function previously returned 0 for input a == 0, but mathematically the number of trailing zeros in the binary representation of 0 is undefined (infinite). Returning 0 was misleading and could cause bugs in algorithms relying on correct trailing zero counts.

Changes

  • Changed if a < 0 to if a <= 0 to catch zero input
  • Removed the 0 if (a == 0) else ternary fallback
  • Updated doctest for binary_count_trailing_zeros(0) to expect ValueError
  • Updated string-input doctest error message from '<' to '<='

Verification

  • ✅ doctest: 9/9 tests passed
  • ✅ ruff: All checks passed
  • ✅ mypy: No issues found

The function previously returned 0 for a == 0, but mathematically
the number of trailing zeros in the binary representation of 0 is
undefined (infinite). Now raises ValueError with a clear message.

Fixes TheAlgorithms#14479
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@kasc0206, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: off-by-one error in binary_count_trailing_zeros for zero input

1 participant