Skip to content

feat(mcp): add Serply search server - #2299

Open
googio wants to merge 1 commit into
ThinkInAIXYZ:devfrom
googio:feat/serply-search
Open

feat(mcp): add Serply search server#2299
googio wants to merge 1 commit into
ThinkInAIXYZ:devfrom
googio:feat/serply-search

Conversation

@googio

@googio googio commented Sep 12, 2026

Copy link
Copy Markdown

Disclosure: I work with Serply (https://serply.io), the provider added by this PR.

Summary

Adds serply-search to DEFAULT_MCP_SERVERS as a disabled-by-default built-in HTTP
MCP server, so users can paste an API key and switch it on instead of hand-writing a
server config.

Serply is a hosted SERP API. One endpoint exposes nine tools: Google, Bing, News,
Scholar, Jobs, Maps and Video search, Amazon Shopping search, and page scraping.

The entry follows the existing mcd-mcp shape for a keyed third-party HTTP server:
type: 'http', a baseUrl, and a customHeaders placeholder the user replaces.
It is not in DEFAULT_ENABLED_SERVER_NAMES, so it ships listed but off, exactly like
the You.com and McDonald's entries.

Two files, 33 added lines, no dependencies, no changes to existing entries.

Testing

Quality gates, all clean on this branch:

pnpm run format:check   All matched files use the correct format (3003 files)
pnpm run lint           agent-cleanup guard, alert-dialog guard, oxlint: exit 0
pnpm run typecheck      typecheck:node exit 0, typecheck:web exit 0
pnpm run test:main      642 files passed, 9064 tests passed, 0 failed

The new Vitest case in test/main/mcp/settings.test.ts mirrors the McDonald's and
You.com cases: it asserts an existing user with an empty mcpServers store picks up
the entry on upgrade with enabled: false and the header placeholder intact.

I also connected to the endpoint with the same client and transport this app uses,
Client plus StreamableHTTPClientTransport with requestInit.headers, reading the
URL and header straight out of the new catalog entry:

entry baseUrl      : https://api.serply.io/mcp
entry header name  : X-Api-Key
entry placeholder  : YOUR_SERPLY_API_KEY
server             : {"name":"serply-mcp-server","version":"1.29.0"}
tools              : 9 -> google_search, google_maps_search, bing_search,
                     google_video_search, google_news_search, google_jobs_search,
                     google_scholar_search, amazon_product_search, scrape_url
google_search      : ok, 788 chars

3 results for "electron mcp client"

1. laststance/electron-mcp-server - GitHub
   https://github.com/laststance/electron-mcp-server
   A powerful Model Context Protocol (MCP) server that provides comprehensive
   Electron application automation, debugging, and observability capabilities.

Behaviour worth knowing before merge, measured against the live endpoint:

  • With no X-Api-Key header the connection is refused with HTTP 401 and a message
    telling the user to supply a Serply API key.
  • With the placeholder left unchanged, initialize and tools/list succeed and the
    first tool call returns isError: true with {"detail":"Invalid API key"}. So a
    user who enables the server before pasting a key gets a clear error naming the
    cause rather than a silent failure.

No renderer strings were added, so pnpm run i18n was not needed. Docs for the tools
are at https://serply.io/docs.

Summary by CodeRabbit

  • New Features

    • Added the Serply Search MCP server to the default server configuration.
    • Configured the server with its API endpoint and API key placeholder.
  • Compatibility

    • Existing users receive the Serply Search server in a disabled state, allowing activation after providing a valid API key.

Add the Serply web search MCP as a disabled-by-default built-in HTTP
server with an X-Api-Key placeholder, so users can paste a key and turn
it on instead of hand-writing a server config. The endpoint exposes
Google, Bing, News, Scholar, Jobs, Maps, Video and Amazon Shopping
search plus page scraping.

Follows the same shape as the mcd-mcp built-in entry.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c4a80d09-7db0-4c60-a470-4c06dd08da21

📥 Commits

Reviewing files that changed from the base of the PR and between f5715f1 and 15f1715.

📒 Files selected for processing (2)
  • src/main/mcp/settings.ts
  • test/main/mcp/settings.test.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The default MCP server configuration now includes the Serply search HTTP server. Tests verify its endpoint, placeholder API key header, HTTP type, and disabled state for existing users without configured MCP servers.

Changes

Serply MCP server

Layer / File(s) Summary
Default Serply server and test coverage
src/main/mcp/settings.ts, test/main/mcp/settings.test.ts
The default settings add the serply-search HTTP server with Serply’s MCP endpoint and placeholder X-Api-Key header. Tests verify that the server is provisioned in a disabled state.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: zerob13

Merge Risk: ⚪ Minimal · up to 15f17

The new server does not activate or make requests for existing users unless they explicitly enable it.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the Serply search MCP server.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zerob13 zerob13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result

No blocking issues found. This adds one disabled-by-default HTTP MCP entry and a focused migration regression test. It follows the existing MCP settings structure and does not change current server behavior.

What I checked

  • The Serply server is not added to the default-enabled list, so it will not connect automatically.
  • The API key is an explicit placeholder only; no real credential is introduced.
  • Existing users receive the configuration only when it is missing; users who removed it remain protected by the existing built-in-server removal tracking.
  • The test covers the important upgrade behavior: URL, header placeholder, type, and disabled state.

Verification

  • git diff --check origin/dev...HEAD passed.
  • The focused Vitest command could not run in the isolated review worktree because dependencies are not installed there (vitest unavailable).

Reference: reviewed head 15f171527ef9c217912c0f3c530f7424b66ff25c against origin/dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants