Add license target to project#395
Open
ViggedalZenseact wants to merge 2 commits into
Open
Conversation
This makes the license observable through Bazel and facilitates for consumers of this project the automated building of an SBOM.
tinder-maxwellelliott
left a comment
tinder-maxwellelliott
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this
| default_visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| license( |
Collaborator
There was a problem hiding this comment.
Lets add a CI step to always build this target to ensure its kept intact
| license_kind = "@@//support/licenses:BSD-3-Clause", | ||
| license_text = "LICENSE", | ||
| package_url = "https://github.com/Tinder/bazel-diff", | ||
| package_version = "29.0.0", |
Collaborator
There was a problem hiding this comment.
Lets update our generate-readme tool to update this file as well to keep this version in sync
Adding a CI step to build the license target to ensure it's kept intact. Modifying generate-readme tool to keep the package_version of the license target in sync with the current version of the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the license observable through Bazel and facilitates for consumers of this project the automated building of an SBOM.