Fix attention calculation on mps for torch 2.8.0#1068
Open
BrownianNotion wants to merge 4 commits intoTransformerLensOrg:mainfrom
Open
Fix attention calculation on mps for torch 2.8.0#1068BrownianNotion wants to merge 4 commits intoTransformerLensOrg:mainfrom
BrownianNotion wants to merge 4 commits intoTransformerLensOrg:mainfrom
Conversation
Author
|
Alternate simpler/less invasive fix - just add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi I'm new here, feedback is welcome/let me know if I've missed anything!
Due to a bug in PyTorch 2.8.0 F.linear for mps pytorch/pytorch#161640, the lines below
from https://github.com/TransformerLensOrg/TransformerLens/blob/main/transformer_lens/components/abstract_attention.py#L302-L306
produce incorrect attention outputs on mps. Cpu works fine. I'm on Mac Sequoia 15.6.1.
I've added a unit test which reproduces the issue in this commit f903629.
To fix this, I have replaced
F.linearwitheinops.einsumwhich is also more consistent with the rest of the class.Related issues: #1008 #1062
Type of change
Please delete options that are not relevant.
Checklist: