Document all four adapter registration locations#1514
Merged
jlarson4 merged 4 commits intoJul 14, 2026
Merged
Conversation
Contributor
Author
|
@jlarson4 ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1511.
The adapter creation guide listed three registration locations while the formal adapter specification listed only two. Both disagreed with the existing four-place invariant in
contributing.mdandsupported_architectures/AGENTS.md.This change:
tools/model_registry/generate_report.pyandARCHITECTURE_DESCRIPTIONSas the fourth registration location;This keeps contributor instructions consistent and reduces the chance that a new adapter loads successfully but has incomplete discovery or generated reporting. No new dependencies are required.
Validation
uv run --locked --python 3.12 build-docs(succeeded; no warnings from the changed files)make check-formatuv run --locked --python 3.12 mypy .Type of change
Checklist