Skip to content

Read bounded SOLIDWORKS configuration scene owners - #191

Open
odinglyn0 wants to merge 2 commits into
mainfrom
codex/solidworks-config-light-actions
Open

odinglyn0 wants to merge 2 commits into
mainfrom
codex/solidworks-config-light-actions

Conversation

@odinglyn0

@odinglyn0 odinglyn0 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

scope

Read actual configuration environment, ambient and directional light owners through the shared member reader. Preserve the signed stored word when SOLIDWORKS clears the runtime value. Populated light properties and complete configuration admission remain open under #121.

Change entry · Exact field and map evidence

verification

The two disclosed version-19000 sources bind the actual scene, earlier name owner, ambient light and observed directional lights. The authored numeric contrast checks distinct wire and runtime values. The guarded cases cover truncated rows and unqualified maps or nested owners. Changed-path steering, diff checks and the donor scan passed. The guarded cases are registered for remote merge-queue validation.


Devin Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · initial analysis · 833 changed lines · 389 reviewable

PR #191 · cdde9dbea6

Total PR diff Reviewable Excluded from review
833 389 53.3%

+828 additions · −5 deletions · 24 files · 0 binary files

Documentation: 5.2%Reverse Engineering: 48.1%Source: 34.9%Tests: 11.8%

Category Additions Deletions Lines Share Files Policy
Documentation +43 −0 43 5.2% 4 excluded
Reverse Engineering +401 −0 401 48.1% 3 excluded
Source +286 −5 291 34.9% 16 review
Tests +98 −0 98 11.8% 1 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

389 reviewable lines; 444 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 24 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Largest changed files
File Category Status Additions Deletions
re/tooling/sw2026/CheckCfgLights.py Reverse Engineering A +184 −0
re/solidworks/measurements/2026/ConfigSceneSource01.json Reverse Engineering A +126 −0
tests/Convert/Solidworks/Configuration/CfgSceneTests.py Tests A +98 −0
re/solidworks/records/ConfigSceneSlice2026.md Reverse Engineering A +91 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/LightFields.py Source A +62 −0
src/convert/adapters/solidworks/Archive/Config/Scene/CheckCfgScene.py Source A +37 −0
src/convert/adapters/solidworks/Archive/Config/Scene/SceneTypes.py Source A +28 −0
src/convert/adapters/solidworks/Archive/Config/Scene/CheckSceneName.py Source A +24 −0
src/convert/adapters/solidworks/Archive/Config/Scene/SceneVirtuals.py Source A +23 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigSceneRecords.md Documentation A +19 −0
Unclassified, renamed, deleted, binary and metadata-only files

Base 66cbe26d65 · merge base 66cbe26d65
Classification b546a07fa1fd5092 · trusted implementation 66cbe26d65
Complete per-file JSON and Markdown · event 44763133901:1

@github-actions github-actions Bot added documentation Improvements or additions to documentation LOW Tests labels Nov 20, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · update #2 · 937 changed lines · 458 reviewable

PR #191 · 28650ee3f0

Total PR diff Reviewable Excluded from review
937 458 51.1%

+914 additions · −23 deletions · 26 files · 0 binary files

Documentation: 4.6%Reverse Engineering: 46.5%Source: 38.0%Tests: 10.9%

Category Additions Deletions Lines Share Files Policy
Documentation +43 −0 43 4.6% 4 excluded
Reverse Engineering +436 −0 436 46.5% 3 excluded
Source +333 −23 356 38.0% 18 review
Tests +102 −0 102 10.9% 1 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

458 reviewable lines; 479 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 26 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Composition changes

Previous cdde9dbea6 → current 28650ee3f0

Net snapshot change: +104 total lines, +69 reviewable lines, -2.2 percentage points excluded.

Category Previous Current Delta
Documentation 43 43 +0
Reverse Engineering 401 436 +35
Source 291 356 +65
Tests 98 102 +4

What changed in this push

Actual head-to-head diff: +117 / −49 across 9 files (0 binary).

  • Documentation: 1 files, +4 / −4
  • Reverse Engineering: 2 files, +39 / −4
  • Source: 5 files, +70 / −41
  • Tests: 1 files, +4 / −0

Net PR snapshot changes are not the lines edited during this push.

Largest changed files
File Category Status Additions Deletions
re/tooling/sw2026/CheckCfgLights.py Reverse Engineering A +210 −0
re/solidworks/measurements/2026/ConfigSceneSource01.json Reverse Engineering A +126 −0
tests/Convert/Solidworks/Configuration/CfgSceneTests.py Tests A +102 −0
re/solidworks/records/ConfigSceneSlice2026.md Reverse Engineering A +100 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/LightFields.py Source A +54 −0
src/convert/adapters/solidworks/Archive/Config/Members/MemberChecks.py Source A +40 −0
src/convert/adapters/solidworks/Archive/Config/Scene/CheckCfgScene.py Source A +35 −0
src/convert/adapters/solidworks/Archive/Config/Scene/SceneTypes.py Source A +28 −0
src/convert/adapters/solidworks/Archive/Config/Members/CheckCfgMember.py Source M +9 −18
src/convert/adapters/solidworks/Archive/Config/Scene/CheckSceneName.py Source A +24 −0
Unclassified, renamed, deleted, binary and metadata-only files
Reviewable size over recent pushes

Base 66cbe26d65 · merge base 66cbe26d65
Classification b546a07fa1fd5092 · trusted implementation 66cbe26d65
Complete per-file JSON and Markdown · event 44765004015:1

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Custom reviewers

  • 📖 Kit Acceptance: no findings · View

Devin Review

Devin autoapproved this pull request: Bounded scene reads retain ownership checks and signed wire values; counted light coverage adds no persistent changes.

Comment on lines +71 to +74
assert ReportValue["counted_variants"] == [
{"directional_count": 1, "slots": [73, 76], "counter": [69, 78]},
{"directional_count": 2, "slots": [73, 76, 78], "counter": [69, 80]},
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 No held-out light count control

The counted_variants cases shorten the same three-light fixture. They exercise count parsing but do not establish that the reader handles a separately saved one- or two-light scene.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Additions documentation Improvements or additions to documentation LOW Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant