Skip to content

Read bounded SOLIDWORKS configuration views and context - #192

Open
odinglyn0 wants to merge 5 commits into
mainfrom
codex/solidworks-config-view-context
Open

odinglyn0 wants to merge 5 commits into
mainfrom
codex/solidworks-config-view-context

Conversation

@odinglyn0

@odinglyn0 odinglyn0 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

scope

Read the ordinary orthographic moView_c member and its two compact transform forms through the shared member reader. Apply the exact archive context actions while preserving the real descriptor and owner slots. Populated view lists, perspective and complete configuration admission remain open under #121.

Change entry · Pinned format evidence

verification

The exact-build reference trace records twenty disclosed view owners and forty transforms with both wire widths. The independent authored context case covers scoped Set, Clear and Assign actions, exact byte positions and preservation of the unrelated context bits. Changed-path steering, diff checks and the donor scan passed. The guarded cases are registered for remote merge-queue validation.


Devin Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · initial analysis · 1,005 changed lines · 314 reviewable

PR #192 · a47aa016a2

Total PR diff Reviewable Excluded from review
1,005 314 68.8%

+1,003 additions · −2 deletions · 19 files · 0 binary files

Documentation: 4.7%Reverse Engineering: 64.1%Source: 20.1%Tests: 11.1%

Category Additions Deletions Lines Share Files Policy
Documentation +47 −0 47 4.7% 4 excluded
Reverse Engineering +644 −0 644 64.1% 3 excluded
Source +200 −2 202 20.1% 10 review
Tests +112 −0 112 11.1% 2 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

314 reviewable lines; 691 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 19 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Largest changed files
File Category Status Additions Deletions
re/solidworks/measurements/2026/ConfigViewSource01.json Reverse Engineering A +294 −0
re/tooling/sw2026/CheckCfgViews.py Reverse Engineering A +244 −0
re/solidworks/records/ConfigViewSlice2026.md Reverse Engineering A +106 −0
tests/Convert/Solidworks/Configuration/CfgViewTests.py Tests A +86 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/ViewFields.py Source A +69 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/GeometryFields.py Source A +58 −0
tests/Convert/Solidworks/Configuration/ReadViewCase.py Tests A +26 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigViewRecords.md Documentation A +19 −0
src/convert/adapters/solidworks/Archive/Bodies/ChangeContext.py Source A +17 −0
src/convert/adapters/solidworks/Archive/Config/Members/CheckCfgView.py Source A +16 −0
Unclassified, renamed, deleted, binary and metadata-only files

Base 66cbe26d65 · merge base 66cbe26d65
Classification b546a07fa1fd5092 · trusted implementation 66cbe26d65
Complete per-file JSON and Markdown · event 44763132790:1

@github-actions github-actions Bot added documentation Improvements or additions to documentation LOW labels Nov 20, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

github-code-quality[bot]

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · update #2 · 1,046 changed lines · 343 reviewable

PR #192 · 86a3227197

Total PR diff Reviewable Excluded from review
1,046 343 67.2%

+1,042 additions · −4 deletions · 21 files · 0 binary files

Documentation: 4.5%Reverse Engineering: 62.7%Source: 21.9%Tests: 10.9%

Category Additions Deletions Lines Share Files Policy
Documentation +47 −0 47 4.5% 4 excluded
Reverse Engineering +656 −0 656 62.7% 3 excluded
Source +225 −4 229 21.9% 12 review
Tests +114 −0 114 10.9% 2 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

343 reviewable lines; 703 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 21 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Composition changes

Previous a47aa016a2 → current 86a3227197

Net snapshot change: +41 total lines, +29 reviewable lines, -1.5 percentage points excluded.

Category Previous Current Delta
Documentation 47 47 +0
Reverse Engineering 644 656 +12
Source 202 229 +27
Tests 112 114 +2

What changed in this push

Actual head-to-head diff: +43 / −6 across 5 files (0 binary).

  • Reverse Engineering: 2 files, +16 / −4
  • Source: 2 files, +25 / −2
  • Tests: 1 files, +2 / −0

Net PR snapshot changes are not the lines edited during this push.

Largest changed files
File Category Status Additions Deletions
re/solidworks/measurements/2026/ConfigViewSource01.json Reverse Engineering A +294 −0
re/tooling/sw2026/CheckCfgViews.py Reverse Engineering A +254 −0
re/solidworks/records/ConfigViewSlice2026.md Reverse Engineering A +108 −0
tests/Convert/Solidworks/Configuration/CfgViewTests.py Tests A +88 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/ViewFields.py Source A +69 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/GeometryFields.py Source A +58 −0
src/convert/adapters/solidworks/Archive/Config/Members/ReadCfgMember.py Source M +24 −2
tests/Convert/Solidworks/Configuration/ReadViewCase.py Tests A +26 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigViewRecords.md Documentation A +19 −0
src/convert/adapters/solidworks/Archive/Bodies/ChangeContext.py Source A +17 −0
Unclassified, renamed, deleted, binary and metadata-only files
Reviewable size over recent pushes

Base 66cbe26d65 · merge base 66cbe26d65
Classification b546a07fa1fd5092 · trusted implementation 66cbe26d65
Complete per-file JSON and Markdown · event 44764533979:1

devin-ai-integration[bot]

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · update #3 · 1,063 changed lines · 360 reviewable

PR #192 · 80b3f6714c

Total PR diff Reviewable Excluded from review
1,063 360 66.1%

+1,059 additions · −4 deletions · 22 files · 0 binary files

Documentation: 4.4%Reverse Engineering: 61.7%Source: 23.2%Tests: 10.7%

Category Additions Deletions Lines Share Files Policy
Documentation +47 −0 47 4.4% 4 excluded
Reverse Engineering +656 −0 656 61.7% 3 excluded
Source +242 −4 246 23.2% 13 review
Tests +114 −0 114 10.7% 2 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

360 reviewable lines; 703 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 22 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Composition changes

Previous 86a3227197 → current 80b3f6714c

Net snapshot change: +17 total lines, +17 reviewable lines, -1.1 percentage points excluded.

Category Previous Current Delta
Documentation 47 47 +0
Reverse Engineering 656 656 +0
Source 229 246 +17
Tests 114 114 +0

What changed in this push

Actual head-to-head diff: +38 / −21 across 3 files (0 binary).

  • Reverse Engineering: 1 files, +10 / −10
  • Source: 2 files, +28 / −11

Net PR snapshot changes are not the lines edited during this push.

Largest changed files
File Category Status Additions Deletions
re/solidworks/measurements/2026/ConfigViewSource01.json Reverse Engineering A +294 −0
re/tooling/sw2026/CheckCfgViews.py Reverse Engineering A +254 −0
re/solidworks/records/ConfigViewSlice2026.md Reverse Engineering A +108 −0
tests/Convert/Solidworks/Configuration/CfgViewTests.py Tests A +88 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/ViewFields.py Source A +69 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/GeometryFields.py Source A +58 −0
tests/Convert/Solidworks/Configuration/ReadViewCase.py Tests A +26 −0
src/convert/adapters/solidworks/Archive/Config/Members/CopyMemberFlags.py Source A +24 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigViewRecords.md Documentation A +19 −0
src/convert/adapters/solidworks/Archive/Config/Members/ReadCfgMember.py Source M +17 −2
Unclassified, renamed, deleted, binary and metadata-only files
Reviewable size over recent pushes

Base 66cbe26d65 · merge base 66cbe26d65
Classification b546a07fa1fd5092 · trusted implementation 2759bcdb61
Complete per-file JSON and Markdown · event 44766974940:1

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · update #4 · 1,063 changed lines · 360 reviewable

PR #192 · cb0ac42c6a

Total PR diff Reviewable Excluded from review
1,063 360 66.1%

+1,059 additions · −4 deletions · 22 files · 0 binary files

Documentation: 4.4%Reverse Engineering: 61.7%Source: 23.2%Tests: 10.7%

Category Additions Deletions Lines Share Files Policy
Documentation +47 −0 47 4.4% 4 excluded
Reverse Engineering +656 −0 656 61.7% 3 excluded
Source +242 −4 246 23.2% 13 review
Tests +114 −0 114 10.7% 2 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

360 reviewable lines; 703 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 22 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Composition changes

Previous 80b3f6714c → current cb0ac42c6a

Net snapshot change: +0 total lines, +0 reviewable lines, +0.0 percentage points excluded.

Category Previous Current Delta
Documentation 47 47 +0
Reverse Engineering 656 656 +0
Source 246 246 +0
Tests 114 114 +0

The merge base changed; snapshot deltas also reflect the updated base.

What changed in this push

Actual head-to-head diff: +1,887 / −0 across 16 files (0 binary).

  • Documentation: 4 files, +59 / −0
  • Reverse Engineering: 4 files, +1,617 / −0
  • Source: 4 files, +87 / −0
  • Tests: 4 files, +124 / −0

Net PR snapshot changes are not the lines edited during this push.

Largest changed files
File Category Status Additions Deletions
re/solidworks/measurements/2026/ConfigViewSource01.json Reverse Engineering A +294 −0
re/tooling/sw2026/CheckCfgViews.py Reverse Engineering A +254 −0
re/solidworks/records/ConfigViewSlice2026.md Reverse Engineering A +108 −0
tests/Convert/Solidworks/Configuration/CfgViewTests.py Tests A +88 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/ViewFields.py Source A +69 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/GeometryFields.py Source A +58 −0
tests/Convert/Solidworks/Configuration/ReadViewCase.py Tests A +26 −0
src/convert/adapters/solidworks/Archive/Config/Members/CopyMemberFlags.py Source A +24 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigViewRecords.md Documentation A +19 −0
src/convert/adapters/solidworks/Archive/Config/Members/ReadCfgMember.py Source M +17 −2
Unclassified, renamed, deleted, binary and metadata-only files
Reviewable size over recent pushes

Base 2759bcdb61 · merge base 2759bcdb61
Classification b546a07fa1fd5092 · trusted implementation 2759bcdb61
Complete per-file JSON and Markdown · event 44768546699:1

devin-ai-integration[bot]
devin-ai-integration Bot previously approved these changes Nov 20, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin autoapproved this pull request: Bounded view reading follows existing dispatch and preserves context without changing production admission.

@github-actions

Copy link
Copy Markdown
Contributor
Diff intelligence · update #5 · 1,063 changed lines · 360 reviewable

PR #192 · 1328f18725

Total PR diff Reviewable Excluded from review
1,063 360 66.1%

+1,059 additions · −4 deletions · 22 files · 0 binary files

Documentation: 4.4%Reverse Engineering: 61.7%Source: 23.2%Tests: 10.7%

Category Additions Deletions Lines Share Files Policy
Documentation +47 −0 47 4.4% 4 excluded
Reverse Engineering +656 −0 656 61.7% 3 excluded
Source +242 −4 246 23.2% 13 review
Tests +114 −0 114 10.7% 2 review

The bar follows the table order. Shares use additions + deletions and reconcile to 100% when text changes exist. Binary files have no fabricated line counts.

Review focus

360 reviewable lines; 703 lines excluded by configured policy. This metric is not a guarantee of low risk.

Classification: 22 files matched deterministic rules or Git metadata; 0 unclassified files remain reviewable. Rule matches express configuration confidence, not semantic or security certainty.

Composition changes

Previous cb0ac42c6a → current 1328f18725

Net snapshot change: +0 total lines, +0 reviewable lines, +0.0 percentage points excluded.

Category Previous Current Delta
Documentation 47 47 +0
Reverse Engineering 656 656 +0
Source 246 246 +0
Tests 114 114 +0

The merge base changed; snapshot deltas also reflect the updated base.

What changed in this push

Actual head-to-head diff: +1,554 / −14 across 24 files (0 binary).

  • Documentation: 4 files, +64 / −13
  • Reverse Engineering: 4 files, +1,100 / −0
  • Source: 12 files, +268 / −1
  • Tests: 4 files, +122 / −0

Net PR snapshot changes are not the lines edited during this push.

Largest changed files
File Category Status Additions Deletions
re/solidworks/measurements/2026/ConfigViewSource01.json Reverse Engineering A +294 −0
re/tooling/sw2026/CheckCfgViews.py Reverse Engineering A +254 −0
re/solidworks/records/ConfigViewSlice2026.md Reverse Engineering A +108 −0
tests/Convert/Solidworks/Configuration/CfgViewTests.py Tests A +88 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/ViewFields.py Source A +69 −0
src/convert/adapters/solidworks/Archive/Bodies/Layouts/Config/GeometryFields.py Source A +58 −0
tests/Convert/Solidworks/Configuration/ReadViewCase.py Tests A +26 −0
src/convert/adapters/solidworks/Archive/Config/Members/CopyMemberFlags.py Source A +24 −0
Documentation/Changes/Solidworks/Archive/SolidworksConfigViewRecords.md Documentation A +19 −0
src/convert/adapters/solidworks/Archive/Config/Members/ReadCfgMember.py Source M +17 −2
Unclassified, renamed, deleted, binary and metadata-only files
Reviewable size over recent pushes

Base b7206312cb · merge base b7206312cb
Classification b546a07fa1fd5092 · trusted implementation b7206312cb
Complete per-file JSON and Markdown · event 44774786235:1

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin autoapproved this pull request: Bounded view reads use shared codecs and reject unsupported forms without changing stored files.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Additions documentation Improvements or additions to documentation LOW Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant