Skip to content

Fix AI combobox aria-activedescendant#2413

Open
Ovgodd wants to merge 1 commit intoTypeCellOS:mainfrom
Ovgodd:fix/a11y-ai-menu
Open

Fix AI combobox aria-activedescendant#2413
Ovgodd wants to merge 1 commit intoTypeCellOS:mainfrom
Ovgodd:fix/a11y-ai-menu

Conversation

@Ovgodd
Copy link
Contributor

@Ovgodd Ovgodd commented Feb 3, 2026

Summary

Fixes AI suggestion menu accessibility by wiring aria-activedescendant to the active option so screen readers announce the current item during keyboard navigation.

issue : #2412

Rationale

The combobox/listbox pattern keeps focus on the input, so the active option must be exposed via aria-activedescendant. Without it, NVDA/VoiceOver announce “empty” and provide no feedback. This change aligns with WAI-ARIA Authoring Practices

Changes

  • Track the active suggestion index in PromptSuggestionMenu and set aria-activedescendant on the input.
  • Extend Generic.Form.TextInput props to accept aria-activedescendant.

Impact

  • Improves screen reader output for the AI suggestion menu.
  • No visual or behavioral changes for sighted users; focus remains on the input.

Testing

  • Manual: verified arrow-key navigation announces the active option in NVDA/VoiceOver.
  • Automated: not added (no existing tests for this component).

Screenshots/Video

Sr announce now :

Ask AI Write with AI  1 sur 1
liste
Continue Writing  1 sur 4
Summarize  2 sur 4
Add Action Items  3 sur 4
Write Anything…  4 sur 4

N/A (accessibility change).

Checklist

  • Code follows the project's coding standards.

Additional Notes

This fix targets only the AI suggestion menu combobox. Future work could add aria-expanded / aria-controls for full parity with the ARIA combobox pattern.

@vercel
Copy link

vercel bot commented Feb 3, 2026

@Ovgodd is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2413

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2413

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2413

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2413

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2413

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2413

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2413

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2413

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2413

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2413

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2413

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2413

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2413

commit: 84d7b45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant