refactor(logger): Upgrade log-update to v8 and drop workaround#1448
Merged
Conversation
log-update v8 fixes the cursor-alignment bug in its diff path where a growing frame would clamp the pre-write cursor move at 0 instead of moving down to the new start row, causing the next erase to eat scrollback above the live region. The InteractiveConsole worked around this by calling logUpdate.clear() whenever the row count changed. With the fix upstream, drop the workaround: remove the lastFrameLineCount bookkeeping, simplify composeLiveRegion() to return just the frame string, and let render() and logAbove() hand that string straight to log-update. Also remove the test that pinned the workaround behaviour and the stale reference in render.js. v8 requires Node >= 22, which this repo already requires.
RandomByte
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log-update v8 fixes the cursor-alignment bug in its diff path where a growing frame would clamp the pre-write cursor move at 0 instead of moving down to the new start row, causing the next erase to eat scrollback above the live region. The InteractiveConsole worked around this by calling logUpdate.clear() whenever the row count changed.
With the fix upstream, drop the workaround: remove the lastFrameLineCount bookkeeping, simplify composeLiveRegion() to return just the frame string, and let render() and logAbove() hand that string straight to log-update. Also remove the test that pinned the workaround behaviour and the stale reference in render.js.
v8 requires Node >= 22, which this repo already requires.