Restrict workspace-level settings to admins - #1571
Draft
RhysSullivan wants to merge 1 commit into
Draft
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 2c3d52f | Commit Preview URL Branch Preview URL |
Aug 12 2026, 10:02 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 2c3d52f | Aug 12 2026, 10:04 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members can still USE workspace resources — read them, execute tools over shared connections, and the operational writes those imply (token refresh, tool-catalog re-sync, config-rewrite healing) — but CONFIGURING them is now admin-only.
What's gated
The executor binding gains
orgWrites: "allowed" | "denied", enforced at the top of every user-intent workspace-level mutation with a newOrgWriteDeniedError(403):Deliberately a surface gate rather than a storage-policy axis: catalog rebuilds, legacy stdio healing, and OAuth token refresh on shared connections must keep converging under any member's binding.
Role plumbing
authorizeOrganizationnow surfaces the WorkOS membership role (no extra API call); HTTP requests and MCP sessions bind from it. MCP sessions bake the role at session init, so a demotion applies from the next session, and sessions persisted before this field existed keep their old behavior until re-init.Tests
packages/core/sdk/src/org-writes.test.ts: denied vs allowed bindings across policies, connections, catalog, OAuth — including that members still execute tools over org connections and that the register replace-arm stays open.apps/host-selfhost/src/multi-user.test.ts: member 403s end-to-end through real Better Auth; admin setup unchanged.format:check,lint,typecheck,test).apps/cloud/src/account/org-api-key-revoke.node.test.tsfails on main already (pre-existing, untouched).Not in this PR
Console UI affordance (hiding the Workspace owner option and catalog mutations for non-admins) — the server now answers 403 and the console renders the error; the nav-level admin gate (
packages/react/src/lib/admin-access.ts) already exists to build on.