Repository navigation
Send the default User-Agent on the MCP endpoint probe - #2258
Merged
Merged
Conversation
RhysSullivan
added this pull request to stack #2260
October 10, 2026 17:53
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | c4af5ce | Oct 10 2026, 05:56 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | c4af5ce | Commit Preview URL Branch Preview URL |
Oct 10 2026, 05:54 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
October 10, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2254 added a default
User-Agent: executorto the MCP transport, but the endpoint shape probe (run when adding a server whose connection attempt fails) still sent its initialize POST, GET fallback, discover POST, and RFC 9728 protected-resource metadata GET with no User-Agent. Servers that reject such requests still failed the add flow.The probe now sets the User-Agent on every request through its HTTP client: the configured one if present, otherwise the default. The constant and helpers move to
user-agent.ts, shared by the transport and the probe.Tests are in #2259.
Verification
vitest run,typecheck; repolintandformat:checkpass.