new fields in rpcInvokeReqExtra #1508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrophysik
reviewed
Jan 22, 2026
apolyakov
reviewed
Jan 22, 2026
astrophysik
reviewed
Jan 22, 2026
astrophysik
reviewed
Jan 23, 2026
| constexpr std::string_view lo_sv = "lo"; | ||
| constexpr std::string_view hi_sv = "hi"; | ||
|
|
||
| const auto underline = string{"_", 1}; |
Contributor
There was a problem hiding this comment.
NIT: include please string header
runtime/interface.cpp
Outdated
|
|
||
| array out{std::pair{underline, mixed{}}, | ||
| std::pair{string{persistent_query_uuid_sv.data(), static_cast<string::size_type>(persistent_query_uuid_sv.size())}, mixed{}}, | ||
| std::pair{string{persistent_slot_uuid_sv.data(), static_cast<string::size_type>(persistent_slot_uuid_sv.size())}, mixed{}}}; |
Contributor
There was a problem hiding this comment.
Same as for runtime-light
apolyakov
reviewed
Jan 23, 2026
PetrShumilov
requested changes
Jan 27, 2026
common/tl/tl-types.h
Outdated
| @@ -0,0 +1,194 @@ | |||
| // Compiler for PHP (aka KPHP) | |||
| // Copyright (c) 2025 LLC «V Kontakte» | |||
Contributor
There was a problem hiding this comment.
Replace 2025 into 2026
| int64_t hi{}; | ||
|
|
||
| bool fetch() { | ||
| lo = tl_fetch_long(); |
Contributor
There was a problem hiding this comment.
nit: Will be better to check error after each fetching attempt. You may lose original error code which is produced by lo = tl_fetch_long();.
apolyakov
reviewed
Jan 27, 2026
| bool return_view_number{}; | ||
|
|
||
| bool fetch(tl::fetcher& tlf) noexcept; | ||
| tl::mask get_flags() const noexcept; |
Contributor
There was a problem hiding this comment.
nit: newline between declarations
apolyakov
approved these changes
Jan 27, 2026
Contributor
apolyakov
left a comment
apolyakov
left a comment
There was a problem hiding this comment.
LGTM except single nit comment
apolyakov
requested changes
Jan 27, 2026
| } | ||
| } | ||
|
|
||
| uint64_t get_flags() const noexcept { |
Contributor
There was a problem hiding this comment.
It should be of type uint32_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added:
persistent_query,trace_context,execution_context