Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNP_ConfigureLanesassignsm_idxPriorityClassinside a loop that starts at the second sorted entry. The lane that sorts first (lowest priority value) is never assigned, so on a reconfiguration it keeps its class index from the previous call. The lanes then get scheduled with the wrong priority. If the old index is no longer valid, it indexes past the end ofm_vecPriorityClasses.This change assigns class 0 to the first sorted lane before the merge loop.
Added
Test_lane_quick_reconfiguretosuite-quick. It configures two lanes with priorities{ 0, 1 }, swaps them to{ 1, 0 }, queues equal data on both, and checks the per lane queue time estimates fromGetConnectionRealTimeStatus. Before the fix, both lanes report 1000 ms. After the fix, lane 1 reports 500 ms and lane 0 reports 1000 ms, as expected.Testing:
test_cryptoandtest_connection suite-quickpass on macOS (Homebrew deps, RelWithDebInfo).Fixes #453