Merged
Conversation
- Introduced `create_progress` and `track_with_progress` for consistent progress tracking. - Updated `upload_dataset_to_langfuse` to support JSON and JSONL formats with improved error handling. - Added tests for dataset upload functionality, ensuring proper metadata handling and error reporting.
There was a problem hiding this comment.
Pull request overview
This PR refactors the Langfuse dataset upload functionality to support both JSON and JSONL formats with automatic format detection, adds reusable Rich progress utilities for improved user experience, and includes comprehensive unit tests for the new parsing and validation logic.
Changes:
- Added reusable progress bar utilities (
create_progressandtrack_with_progress) for consistent progress visualization - Enhanced
upload_dataset_to_langfuseto auto-detect format, validate records, and provide better error messages with line numbers - Added focused unit tests covering JSON/JSONL upload, malformed data handling, and progress helper functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| aieng-eval-agents/aieng/agent_evals/progress.py | Introduces reusable Rich progress utilities with standardized column layout |
| aieng-eval-agents/aieng/agent_evals/langfuse.py | Refactors dataset upload with format detection, improved validation, and progress tracking |
| aieng-eval-agents/aieng/agent_evals/init.py | Exports new progress utilities for public API |
| aieng-eval-agents/tests/aieng/agent_evals/test_langfuse.py | Adds comprehensive unit tests for upload parsing, validation, and progress helpers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amrit110
requested changes
Feb 4, 2026
Member
amrit110
left a comment
There was a problem hiding this comment.
Just the one comment! Overall looks good.
amrit110
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors Langfuse dataset upload to support both JSONL and JSON inputs (with format auto-detection), adds a reusable Rich progress utility for progress UX, and adds focused unit tests for upload parsing/validation behaviour.
Clickup Ticket(s): N/A
Type of Change
Changes Made
aieng-eval-agents/aieng/agent_evals/progress.py(create_progressandtrack_with_progress) and exported them inaieng-eval-agents/aieng/agent_evals/__init__.py.upload_dataset_to_langfuseinaieng-eval-agents/aieng/agent_evals/langfuse.pyto:input,expected_output),idfallback handling),aieng-eval-agents/tests/aieng/agent_evals/test_langfuse.pycovering JSON upload, JSONL upload, malformed JSONL handling, missing required fields, and progress helper smoke checks.Testing
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
N/A
Screenshots/Recordings
N/A
Related Issues
N/A
Deployment Notes
Checklist