Skip to content

Add missing launch condition for --hf-model#228

Merged
XkunW merged 2 commits intomainfrom
bugfix/misc
Apr 8, 2026
Merged

Add missing launch condition for --hf-model#228
XkunW merged 2 commits intomainfrom
bugfix/misc

Conversation

@XkunW
Copy link
Copy Markdown
Contributor

@XkunW XkunW commented Apr 8, 2026

PR Type

[Fix]

Short Description

Missing a condition check for --hf-model, vec-inf launch currently fails if weights aren't cached, added a condition so that --hf-model passes through.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.91%. Comparing base (6a10556) to head (1532fd1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
vec_inf/client/_helper.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   89.97%   89.91%   -0.06%     
==========================================
  Files          14       14              
  Lines        1466     1468       +2     
==========================================
+ Hits         1319     1320       +1     
- Misses        147      148       +1     
Files with missing lines Coverage Δ
vec_inf/client/_helper.py 92.75% <50.00%> (-0.21%) ⬇️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XkunW XkunW merged commit 9b3af8f into main Apr 8, 2026
7 checks passed
@XkunW XkunW deleted the bugfix/misc branch April 8, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants