Fix compiler crash on Rails main after template_handler_extensions removal#2662
Open
luizkowalski wants to merge 1 commit into
Open
Conversation
…moval Rails removed ActionView::Template.template_handler_extensions in rails/rails#57874. Read the registered extensions through ActionView::Template::Handlers.extensions instead, which works on all supported Rails versions (7.1+).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails removed
ActionView::Template.template_handler_extensionsin rails/rails#57874, so the compiler crashes withNoMethodErrorwhen gathering sidecar templates on Rails main.This reads the registered extensions through
ActionView::Template::Handlers.extensionsinstead. That method is the supported read-path API and exists on every supported Rails version (7.1+), so no version check is needed.Tested: full sandbox suite green on Rails 8.1; confirmed the old call raises and the new one works against the actual PR commit.