Skip to content

refactor(Application): Remove unnecessary super() calls #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirokiterashima merged 1 commit into from
Feb 27, 2026
Merged

refactor(Application): Remove unnecessary super() calls #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/app/teacher/share-run-dialog/share-run-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ export class ShareRunDialogComponent extends ShareItemDialogComponent {
});
}

ngOnInit() {
super.ngOnInit();
}

updateAllOwners() {
let allOwners = [];
allOwners.push({
Expand Down
4 changes: 0 additions & 4 deletions src/assets/wise5/components/animation/animation-student/animation-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ export class AnimationStudent extends ComponentStudent {
this.setupSVG();
}

ngOnDestroy(): void {
super.ngOnDestroy();
}

setAnimationState(state: string): void {
this.animationState = state;
}
Expand Down
4 changes: 0 additions & 4 deletions src/assets/wise5/components/discussion/discussion-student/discussion-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,6 @@ export class DiscussionStudent extends ComponentStudent {
this.broadcastDoneRenderingComponent();
}

ngOnDestroy(): void {
super.ngOnDestroy();
}

isConnectedComponentShowWorkMode() {
if (this.component.hasConnectedComponent()) {
let isShowWorkMode = true;
Expand Down
4 changes: 0 additions & 4 deletions src/assets/wise5/components/graph/graph-student/graph-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@ export class GraphStudent extends ComponentStudent {
});
}

ngOnDestroy(): void {
super.ngOnDestroy();
}

initializeComponentContentParams() {
this.title = this.componentContent.title;
this.subtitle = this.componentContent.subtitle;
Expand Down
4 changes: 0 additions & 4 deletions src/assets/wise5/components/summary/summary-student/summary-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ export class SummaryStudent extends ComponentStudent {
this.setPeriodIdIfNecessary();
}

ngOnDestroy(): void {
super.ngOnDestroy();
}

getOtherPrompt(nodeId, componentId) {
const otherComponent = this.projectService.getComponent(nodeId, componentId);
if (otherComponent != null) {
Expand Down
4 changes: 0 additions & 4 deletions src/assets/wise5/components/table/table-student/table-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,6 @@ export class TableStudentComponent extends ComponentStudent {
}
}

ngOnDestroy(): void {
super.ngOnDestroy();
}

initializeDataExplorer() {
this.numDataExplorerSeries = this.componentContent.numDataExplorerSeries;
this.dataExplorerGraphTypes = this.componentContent.dataExplorerGraphTypes;
Expand Down
32 changes: 16 additions & 16 deletions src/messages.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9914,7 +9914,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
<source>Transferred classroom unit ownership to <x id="firstName" equiv-text="run.owner.firstName"/> <x id="lastName" equiv-text="run.owner.lastName"/>.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/app/teacher/share-run-dialog/share-run-dialog.component.ts</context>
<context context-type="linenumber">213</context>
<context context-type="linenumber">209</context>
</context-group>
</trans-unit>
<trans-unit id="3392754525167799121" datatype="html">
Expand Down Expand Up @@ -16770,7 +16770,7 @@ Are you sure you want to proceed?</source>
<source>You do not have any more chances to receive feedback on your answer.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/animation/animation-student/animation-student.component.ts</context>
<context context-type="linenumber">926</context>
<context context-type="linenumber">922</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/openResponse/open-response-student/open-response-student.component.ts</context>
Expand All @@ -16787,7 +16787,7 @@ Are you sure you want to proceed?</source>
Are you ready to receive feedback on this answer?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/animation/animation-student/animation-student.component.ts</context>
<context context-type="linenumber">929</context>
<context context-type="linenumber">925</context>
</context-group>
</trans-unit>
<trans-unit id="1556483130839173989" datatype="html">
Expand All @@ -16796,7 +16796,7 @@ Are you ready to receive feedback on this answer?</source>
Are you ready to receive feedback on this answer?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/animation/animation-student/animation-student.component.ts</context>
<context context-type="linenumber">933</context>
<context context-type="linenumber">929</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
Expand Down Expand Up @@ -18272,7 +18272,7 @@ Category Name: <x id="PH_1" equiv-text="categoryName"/></source>
<source><x id="PH" equiv-text="usernames"/> replied to a discussion you were in!</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/discussion/discussion-student/discussion-student.component.ts</context>
<context context-type="linenumber">224</context>
<context context-type="linenumber">220</context>
</context-group>
</trans-unit>
<trans-unit id="831017338718169987" datatype="html">
Expand Down Expand Up @@ -19424,46 +19424,46 @@ Category Name: <x id="PH_1" equiv-text="categoryName"/></source>
<source>Are you sure you want to overwrite the current line data?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">263</context>
<context context-type="linenumber">259</context>
</context-group>
</trans-unit>
<trans-unit id="6882380861047606832" datatype="html">
<source>The series you are trying to add a point to is currently hidden. Please show the series by clicking the series name in the legend and try adding the point again.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">886</context>
<context context-type="linenumber">882</context>
</context-group>
</trans-unit>
<trans-unit id="2852989551014711458" datatype="html">
<source>You can not edit this series. Please choose a series that can be edited.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">900</context>
<context context-type="linenumber">896</context>
</context-group>
</trans-unit>
<trans-unit id="7053114367342967943" datatype="html">
<source>Are you sure you want to reset the series?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">1133</context>
<context context-type="linenumber">1129</context>
</context-group>
</trans-unit>
<trans-unit id="7889560203726829643" datatype="html">
<source>Are you sure you want to reset the &quot;<x id="PH" equiv-text="seriesName"/>&quot; series?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">1135</context>
<context context-type="linenumber">1131</context>
</context-group>
</trans-unit>
<trans-unit id="6999515396807067782" datatype="html">
<source>Trial</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">1552</context>
<context context-type="linenumber">1548</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/graph/graph-student/graph-student.component.ts</context>
<context context-type="linenumber">2384</context>
<context context-type="linenumber">2380</context>
</context-group>
</trans-unit>
<trans-unit id="7500488806315952979" datatype="html">
Expand Down Expand Up @@ -21286,28 +21286,28 @@ If this problem continues, let your teacher know and move on to the next activit
<source>You must submit work on &quot;<x id="PH" equiv-text="this.otherStepTitle"/>&quot; to view the summary.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/summary/summary-student/summary-student.component.ts</context>
<context context-type="linenumber">138</context>
<context context-type="linenumber">134</context>
</context-group>
</trans-unit>
<trans-unit id="3834814461916183420" datatype="html">
<source>You must complete &quot;<x id="PH" equiv-text="this.otherStepTitle"/>&quot; to view the summary.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/summary/summary-student/summary-student.component.ts</context>
<context context-type="linenumber">140</context>
<context context-type="linenumber">136</context>
</context-group>
</trans-unit>
<trans-unit id="1745852243024604075" datatype="html">
<source>You must submit work on &quot;<x id="PH" equiv-text="this.otherStepTitle"/>&quot; to view the class summary.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/summary/summary-student/summary-student.component.ts</context>
<context context-type="linenumber">146</context>
<context context-type="linenumber">142</context>
</context-group>
</trans-unit>
<trans-unit id="8412691431688558361" datatype="html">
<source>You must complete &quot;<x id="PH" equiv-text="this.otherStepTitle"/>&quot; to view the class summary.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/summary/summary-student/summary-student.component.ts</context>
<context context-type="linenumber">148</context>
<context context-type="linenumber">144</context>
</context-group>
</trans-unit>
<trans-unit id="6594489851569621957" datatype="html">
Expand Down
Loading