Repository navigation
Conversation
dbus_name_as_prefix() only maps ':', digits and '.'; every other character became '\0' via std::unordered_map::operator[]. Well-known names such as Electron's org.freedesktop.StatusNotifierItem-2916-1 therefore produced a prefix with NULs, the menu's actions were not found under it, and clicking a menu entry did nothing. Keep mapped characters as before, pass ASCII letters through and map anything else to 'y'. Unique names (:1.42) give the same prefix as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
The failing "Check code style with uncrustify" job isn't about this change: it fails while building uncrustify ("Compatibility with CMake < 3.5 has been removed from CMake", "Configuring incomplete"), the same as on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576.
dbus_name_as_prefix()only maps:, digits and.; every other character became'\0'viastd::unordered_map::operator[]. Well-known names such as Electron'sorg.freedesktop.StatusNotifierItem-2916-1therefore produced a prefix with NULs, the menu's actions were not found under it, and clicking an entry did nothing.Keep mapped characters as before, pass ASCII letters through unchanged, and map anything else (e.g.
-) to'y', which isn't used by the existing mapping. Unique names (:1.42) give exactly the same prefix as before.Tested: Claude Desktop's tray menu entries now work; tray items with unique names behave as before.
🤖 Generated with Claude Code