[wasm-split] Deduplicate loops in shareImportableItems (NFC) - #8992
Open
aheejin wants to merge 2 commits into
Open
[wasm-split] Deduplicate loops in shareImportableItems (NFC)#8992aheejin wants to merge 2 commits into
aheejin wants to merge 2 commits into
Conversation
We have six mostly identical loops in `shareImportableItems`, each for memories, tables, globals, tags, data segments, and element segments. This factors the core logic out as a generic lambda function.
tlively
approved these changes
Aug 13, 2026
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
Nice! LGTM once the preliminaries land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have six mostly identical loops in
shareImportableItems, each for memories, tables, globals, tags, data segments, and element segments. This factors the core logic out as a generic lambda function.