You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider using lang attribute for TodoMVC forms that use japanese characters #516
In particular, I have observed that several of the TodoMVC tests, in particular TodoMVC-JavaScript-ES5 uses Japanese text without language tagging and without specifying a font that supports the Japanese glyphs to be rendered, forcing a font fallback path.
In the context of the intention of this sub-bench, I don't think this is a code path that should be exercised here. For content on the web, I would usually suggest to provide either web- or system-font coverage and add language tagging.
If the intention is to test fallback, that could be made explicit in a different test.
changed the title [-]Consider using lang attribute for RodoMVC forms that use japanese characters[/-][+]Consider using lang attribute for TodoMVC forms that use japanese characters[/+]on Jun 12, 2025
Activity
drott commentedon Jun 12, 2025
+1, in addition, this is and related pages might be useful resources.
In particular, I have observed that several of the TodoMVC tests, in particular
TodoMVC-JavaScript-ES5uses Japanese text without language tagging and without specifying a font that supports the Japanese glyphs to be rendered, forcing a font fallback path.In the context of the intention of this sub-bench, I don't think this is a code path that should be exercised here. For content on the web, I would usually suggest to provide either web- or system-font coverage and add language tagging.
If the intention is to test fallback, that could be made explicit in a different test.
[-]Consider using lang attribute for RodoMVC forms that use japanese characters[/-][+]Consider using lang attribute for TodoMVC forms that use japanese characters[/+]