Skip to content

Consider using lang attribute for TodoMVC forms that use japanese characters #516

Open

Description

@camillobruni

This would follow best practise a bit better and make it clearer that we want to render non-english test.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/lang

Activity

  1. drott commented on Jun 12, 2025

    @drott

    +1, in addition, this is and related pages might be useful resources.

    In particular, I have observed that several of the TodoMVC tests, in particular TodoMVC-JavaScript-ES5 uses Japanese text without language tagging and without specifying a font that supports the Japanese glyphs to be rendered, forcing a font fallback path.

    In the context of the intention of this sub-bench, I don't think this is a code path that should be exercised here. For content on the web, I would usually suggest to provide either web- or system-font coverage and add language tagging.

    If the intention is to test fallback, that could be made explicit in a different test.

  2. changed the title [-]Consider using lang attribute for RodoMVC forms that use japanese characters[/-] [+]Consider using lang attribute for TodoMVC forms that use japanese characters[/+] on Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions